ImpressCMS/impresscms

Avoid deeply nested control flow statements.

Open

                            if (!preg_match("/^http[s]*:\/\//i", $results[$i]['link'])) {
                                $results[$i]['link'] = "modules/" . $moddir . "/" . $results[$i]['link'];
                            }

Avoid deeply nested control flow statements.

Open

                    if (!copy($src, $dest)) {
                        $error[] = sprintf(_FAILSAVEIMG, $image_id[$i]);
                    }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

this.show = function(id) { var el = new Element(id); document.getElementById(id).className = (el.level == 1 ? "button-active" : "item-active"); if (el.level > 1 && this.arrow2) { document.getElementById(id + "-arrow").src = this.arrow2;}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

this.hide = function(id) { var el = new Element(id); document.getElementById(id).className = (el.level == 1 ? "button" : "item"); if (el.level > 1 && this.arrow2) { document.getElementById(id + "-arrow").src = this.arrow1;}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

Form.Observer = Class.create(Abstract.TimedObserver, {
    getValue: function() {
        return Form.serialize(this.element);
    }
});

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

Form.EventObserver = Class.create(Abstract.EventObserver, {
    getValue: function() {
        return Form.serialize(this.element);
    }
});

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            } elseif (function_exists('icms_module_update_'.$ModName)) {
                $func = 'icms_module_update_'.$ModName;
                if (!$func($module, $prev_version, $prev_dbversion)) {
                    $msgs[] = sprintf(_MD_AM_FAIL_EXEC, '<strong>' . $func . '</strong>');
                } else {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    if (!empty($user_reg_more) && is_numeric($user_reg_more)) {
        $f_user_reg_more = (int) trim($user_reg_more);
        $time = time() - (60 * 60 * 24 * $f_user_reg_more);
        if ($time > 0) {
            $criteria->add(new icms_db_criteria_Item('user_regdate', $time, '<'));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (gethostbyname($host) != $host) {
                $this->protector->message .= "DENY by $rbl_name\n";
                $uid = is_object(icms::$user) ? icms::$user->getVar('uid') : 0;
                $this->protector->output_log('RBL SPAM', $uid, false, 128);
                die(_MD_PROTECTOR_DENYBYRBL);

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        if (!$table->fieldExists('enc_type')) {
            $sql = "ALTER TABLE `" . $GLOBALS['xoopsDB']->prefix('users') . "` ADD enc_type tinyint(2) unsigned NOT NULL default '0'";
            if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
                icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                return false;

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        if (!$table->fieldExists('pass_expired')) {
            $sql = "ALTER TABLE `" . $GLOBALS['xoopsDB']->prefix('users') . "` ADD pass_expired tinyint(1) NOT NULL default '0'";
            if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
                icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                return false;

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        if (!$table->fieldExists('openid')) {
            $sql = "ALTER TABLE `" . $GLOBALS['xoopsDB']->prefix('users') . "` ADD openid varchar(255) NOT NULL default ''";
            if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
                icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                return false;

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    if (!empty($user_lastlog_less) && is_numeric($user_lastlog_less)) {
        $f_user_lastlog_less = (int) trim($user_lastlog_less);
        $time = time() - (60 * 60 * 24 * $f_user_lastlog_less);
        if ($time > 0) {
            $criteria->add(new icms_db_criteria_Item('last_login', $time, '>'));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (gethostbyname($host) != $host) {
                $this->protector->message .= "DENY by $rbl\n";
                $uid = is_object(icms::$user) ? icms::$user->getVar('uid') : 0;
                $this->protector->output_log('RBL SPAM', $uid, false, 128);
                die(_MD_PROTECTOR_DENYBYRBL);

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        if (!$table->fieldExists('salt')) {
            $sql = "ALTER TABLE `" . $GLOBALS['xoopsDB']->prefix('users') . "` ADD salt varchar(255) NOT NULL default ''";
            if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
                icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                return false;

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    if (!empty($user_lastlog_more) && is_numeric($user_lastlog_more)) {
        $f_user_lastlog_more = (int) trim($user_lastlog_more);
        $time = time() - (60 * 60 * 24 * $f_user_lastlog_more);
        if ($time > 0) {
            $criteria->add(new icms_db_criteria_Item('last_login', $time, '<'));

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

        if (!$table->fieldExists('user_viewoid')) {
            $sql = "ALTER TABLE `" . $GLOBALS['xoopsDB']->prefix('users') . "` ADD user_viewoid tinyint(1) unsigned NOT NULL default '0'";
            if (!$result = $GLOBALS['xoopsDB']->queryF($sql)) {
                icms_debug('An error occurred while executing "' . $sql . '" - ' . $GLOBALS['xoopsDB']->error());
                return false;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if (function_exists('xoops_module_update_'.$ModName)) {
                $func = 'xoops_module_update_'.$ModName;
                if (!$func($module, $prev_version, $prev_dbversion)) {
                    $msgs[] = sprintf(_MD_AM_FAIL_EXEC, '<strong>' . $func . '</strong>');
                } else {

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

        if (/\d/.test(value) && element && element.runtimeStyle && !(isPercentage && isViewport)) {
            var style = element.style.left, rStyle = element.runtimeStyle.left;
            element.runtimeStyle.left = element.currentStyle.left;
            element.style.left = value || 0;
            value = element.style.pixelLeft;

Consider simplifying this complex logical expression.

Open

        if ( support.matchesSelector && documentIsHTML &&
            ( !rbuggyMatches || !rbuggyMatches.test( expr ) ) &&
            ( !rbuggyQSA     || !rbuggyQSA.test( expr ) ) ) {

            try {