Sign upLogin

ImpressCMS/impresscms

View on GitHub
Star

Showing 47,251 of 47,256 total issues

Function openWithSelfMain has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

function openWithSelfMain(url,name,width,height,returnwindow) {
Severity: Minor
Found in htdocs/include/xoops.js - About 35 mins to fix

    Function xoopsCodeCode has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function xoopsCodeCode(id, enterCodePhrase, enterCodeLangPhrase, CodeLangTypePhrase, errorCodeLangPhrase){
    Severity: Minor
    Found in htdocs/include/xoops.js - About 35 mins to fix

      Function TCBuildCell has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function TCBuildCell (R, G, B, w, h) {
      Severity: Minor
      Found in htdocs/include/color-picker.js - About 35 mins to fix

        Function showImgSelected has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function showImgSelected(imgId, selectId, imgDir, extra, xoopsUrl) {
        Severity: Minor
        Found in htdocs/include/xoops.js - About 35 mins to fix

          Function xoopsCodeImg has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function xoopsCodeImg(id, enterImgUrlPhrase, enterImgPosPhrase, imgPosRorLPhrase, errorImgPosPhrase){
          Severity: Minor
          Found in htdocs/include/xoops.js - About 35 mins to fix

            Function filter_preview has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function filter_preview(id,xurl,img,width,height){
            Severity: Minor
            Found in htdocs/modules/system/admin/images/js/imanager.js - About 35 mins to fix

              Method xoFormFieldCharset has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function xoFormFieldCharset($name, $value, $label, $link, $help = '') {
              Severity: Minor
              Found in htdocs/install/page_dbsettings.php - About 35 mins to fix

                Method xoFormField has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function xoFormField( $name, $value, $label, $maxlength, $help = '' )
                Severity: Minor
                Found in upgrade/upd-icms-1.0-to-1.1/settings_salt.php - About 35 mins to fix

                  Method icmsFormField has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function icmsFormField( $name, $value, $label, $maxlength, $help = '' )
                  Severity: Minor
                  Found in upgrade/upd-icms-1.0-to-1.1/settings_trust_path.php - About 35 mins to fix

                    Method xoFormField has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    function xoFormField($name, $value, $label, $maxlength, $help = '') {
                    Severity: Minor
                    Found in htdocs/install/page_dbsettings.php - About 35 mins to fix

                      Method redirect_header has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      function redirect_header($url, $time = 3, $message = '', $addredirect = true, $allowExternalLink = false)
                      Severity: Minor
                      Found in htdocs/include/functions.php - About 35 mins to fix

                        Method xoFormField has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        function xoFormField( $name, $value, $label, $help = '', $type='text') {
                        Severity: Minor
                        Found in htdocs/install/page_dbconnection.php - About 35 mins to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              Event.Methods = {
        isLeftClick:   isLeftClick,
        isMiddleClick: isMiddleClick,
        isRightClick:  isRightClick,
                          Severity: Minor
                          Found in htdocs/install/prototype.js and 1 other location - About 35 mins to fix
                          htdocs/install/prototype.js on lines 2531..2541

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 47.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          nodes[i].id = id + "-" + (tree.length - 1) + "-section"; var box1 = document.getElementById(id + "-" + (tree.length - 1)); var box2 = document.getElementById(nodes[i].id); var el = new Element(box1.id); if (el.level == 1) { if (this.type == "horizontal") { box2.style.top = (box1.offsetTop + box1.offsetHeight + this.position.level1.top) + "px"; if (this.browser.ie5) { box2.style.left = (this.position.level1.left) + "px";} else {
                          Severity: Minor
                          Found in htdocs/include/icms_rtl.js and 1 other location - About 35 mins to fix
                          htdocs/include/icms_rtl.js on lines 43..43

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 47.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          } else if (this.type == "vertical") { box2.style.top = (box1.offsetTop + this.position.level1.top) + "px"; if (this.browser.ie5) { box2.style.left = (box1.offsetWidth + this.position.level1.left) + "px";} else { box2.style.left = (box1.offsetLeft + box1.offsetWidth + this.position.level1.Left) + "px";}
                          Severity: Minor
                          Found in htdocs/include/icms_rtl.js and 1 other location - About 35 mins to fix
                          htdocs/include/icms_rtl.js on lines 39..39

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 47.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              Object.extend(methods, {
        remove:  remove,
        update:  update,
        replace: replace,
        insert:  insert,
                          Severity: Minor
                          Found in htdocs/install/prototype.js and 1 other location - About 35 mins to fix
                          htdocs/install/prototype.js on lines 6823..6836

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 47.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 3 locations. Consider refactoring.
                          Open

                              if ($mod->getInfo('image') != FALSE && trim($mod->getInfo('image')) != '') {
        $msgs ='<img src="' . ICMS_MODULES_URL . '/' . $mod->getVar('dirname') . '/' . trim($mod->getInfo('image')) . '" alt="" />';

    }
                          Severity: Minor
                          Found in htdocs/modules/system/admin/modulesadmin/main.php and 2 other locations - About 35 mins to fix
                          htdocs/modules/system/admin/modulesadmin/main.php on lines 222..225
                          htdocs/modules/system/admin/modulesadmin/main.php on lines 300..303

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 92.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                                  $pattern = array ("/%09/", "/%20/", "/%21/", "/%22/", "/%23/", "/%25/", "/%26/", "/%27/", "/%28/", "/%29/", "/%2C/", "/%2F/", "/%3A/", "/%3B/", "/%3C/", "/%3D/", "/%3E/", "/%3F/", "/%40/", "/%5B/", "/%5C/", "/%5D/", "/%5E/", "/%7B/", "/%7C/", "/%7D/", "/%7E/", "/\./" );
                          Severity: Major
                          Found in htdocs/modules/system/admin/adsense/class/adsense.php and 4 other locations - About 35 mins to fix
                          htdocs/install/modulesadmin.php on lines 25..25
                          htdocs/modules/system/admin/adsense/class/adsense.php on lines 185..185
                          htdocs/modules/system/admin/modulesadmin/modulesadmin.php on lines 124..152
                          htdocs/modules/system/admin/modulesadmin/modulesadmin.php on lines 605..633

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 92.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 5 locations. Consider refactoring.
                          Open

                              $reservedTables = array('avatar',
        'avatar_users_link',
        'block_module_link',
        'xoopscomments',
        'config',
                          Severity: Major
                          Found in htdocs/modules/system/admin/modulesadmin/modulesadmin.php and 4 other locations - About 35 mins to fix
                          htdocs/install/modulesadmin.php on lines 25..25
                          htdocs/modules/system/admin/adsense/class/adsense.php on lines 184..184
                          htdocs/modules/system/admin/adsense/class/adsense.php on lines 185..185
                          htdocs/modules/system/admin/modulesadmin/modulesadmin.php on lines 124..152

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 92.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 3 locations. Consider refactoring.
                          Open

                              if ($mod->getInfo('image') != FALSE && trim($mod->getInfo('image')) != '') {
        $msgs ='<img src="' . ICMS_MODULES_URL . '/' . $mod->getVar('dirname') . '/' . trim($mod->getInfo('image')) . '" alt="" />';

    }
                          Severity: Minor
                          Found in htdocs/modules/system/admin/modulesadmin/main.php and 2 other locations - About 35 mins to fix
                          htdocs/modules/system/admin/modulesadmin/main.php on lines 265..268
                          htdocs/modules/system/admin/modulesadmin/main.php on lines 300..303

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 92.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language