Sign upLogin

JeffDeCola/jeffCoin

View on GitHub
Star
wallet/wallet-interface.go

Summary

Maintainability
B
6 hrs
Test Coverage

Function TransactionRequest has 70 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TransactionRequest(nodeIP string, nodeTCPPort string, transactionRequestMessageSigned string) (string, error) {

    s := "START  TransactionRequest() - Request to transfer Coins to a jeffCoin Address"
    log.Debug("WALLET:      I/F      " + s)
Severity: Minor
Found in wallet/wallet-interface.go - About 1 hr to fix

    Function RequestAddressBalance has 69 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func RequestAddressBalance(IP string, TCPPort string, jeffCoinAddress string) (string, error) {

    s := "START  RequestAddressBalance() - Requests the jeffCoin balance for a jeffCoin Address"
    log.Debug("WALLET:      I/F      " + s)
    Severity: Minor
    Found in wallet/wallet-interface.go - About 1 hr to fix

      Function RequestAddressBalance has 5 return statements (exceeds 4 allowed).
      Open

      func RequestAddressBalance(IP string, TCPPort string, jeffCoinAddress string) (string, error) {

    s := "START  RequestAddressBalance() - Requests the jeffCoin balance for a jeffCoin Address"
    log.Debug("WALLET:      I/F      " + s)
      Severity: Major
      Found in wallet/wallet-interface.go - About 35 mins to fix

        Function TransactionRequest has 5 return statements (exceeds 4 allowed).
        Open

        func TransactionRequest(nodeIP string, nodeTCPPort string, transactionRequestMessageSigned string) (string, error) {

    s := "START  TransactionRequest() - Request to transfer Coins to a jeffCoin Address"
    log.Debug("WALLET:      I/F      " + s)
        Severity: Major
        Found in wallet/wallet-interface.go - About 35 mins to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          func GenesisWallet(nodeName string, passwordString string) {

    s := "START  GenesisWallet() - Creates the wallet and writes to file (Keys and jeffCoin Address)"
    log.Debug("WALLET:      I/F      " + s)
          Severity: Major
          Found in wallet/wallet-interface.go and 3 other locations - About 1 hr to fix
          wallet/wallet-interface.go on lines 55..70
          webserver/webserver-interface.go on lines 29..44
          webserver/webserver-interface.go on lines 47..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 134.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          func ReadWalletFile(nodeName string, passwordString string) {

    s := "START  ReadWalletFile() - Reads the wallet from a file and puts in struct"
    log.Debug("WALLET:      I/F      " + s)
          Severity: Major
          Found in wallet/wallet-interface.go and 3 other locations - About 1 hr to fix
          wallet/wallet-interface.go on lines 37..52
          webserver/webserver-interface.go on lines 29..44
          webserver/webserver-interface.go on lines 47..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 134.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status