Jelle-S/TheSportsDb

View on GitHub
src/Entity/Entity.php

Summary

Maintainability
A
1 hr
Test Coverage

The class Entity has 12 public methods. Consider refactoring Entity to keep number of public methods under 10.
Open

abstract class Entity implements EntityInterface {

  /**
   * The property map definition.
   *
Severity: Minor
Found in src/Entity/Entity.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Function raw has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  public function raw() {
    if (isset($this->_raw)) {
      return $this->_raw;
    }
    $this->_raw = new \stdClass();
Severity: Minor
Found in src/Entity/Entity.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method transform has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  public static function transform($value, $context, EntityManagerInterface $entityManager, $entityType, $idName, array $contextPropertyMap = array()) {
Severity: Minor
Found in src/Entity/Entity.php - About 45 mins to fix

    Missing class import via use statement (line '45', column '23').
    Open

        $reflection = new \ReflectionClass($this);
    Severity: Minor
    Found in src/Entity/Entity.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '210', column '17').
    Open

        $date = new \DateTime($value);
    Severity: Minor
    Found in src/Entity/Entity.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '44', column '23').
    Open

        $this->_raw = new \stdClass();
    Severity: Minor
    Found in src/Entity/Entity.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '79', column '23').
    Open

        $reflection = new \ReflectionClass(static::class);
    Severity: Minor
    Found in src/Entity/Entity.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\TheSportsDb\Entity\EntityPropertyUtil' in method 'raw'.
    Open

              $this->_raw->{$prop} = EntityPropertyUtil::getRawValue($val);
    Severity: Minor
    Found in src/Entity/Entity.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid unused parameters such as '$context'.
    Open

      public static function reverse($entity, $context, EntityManagerInterface $entityManager) {
    Severity: Minor
    Found in src/Entity/Entity.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$entityManager'.
    Open

      public static function reverse($entity, $context, EntityManagerInterface $entityManager) {
    Severity: Minor
    Found in src/Entity/Entity.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
    {
        private function bar($howdy)
        {
            // $howdy is not used
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    The variable $time_parts is not named in camelCase.
    Open

      public static function transformDateTime($value, $format, $time = NULL) {
        $date = new \DateTime($value);
        $date->createFromFormat($format, $value);
        if ($time && $time !== EntityManager::EMPTYPROPERTYPLACEHOLDER) {
          $time_parts = explode(':', $time);
    Severity: Minor
    Found in src/Entity/Entity.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $time_parts is not named in camelCase.
    Open

      public static function transformDateTime($value, $format, $time = NULL) {
        $date = new \DateTime($value);
        $date->createFromFormat($format, $value);
        if ($time && $time !== EntityManager::EMPTYPROPERTYPLACEHOLDER) {
          $time_parts = explode(':', $time);
    Severity: Minor
    Found in src/Entity/Entity.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $time_parts is not named in camelCase.
    Open

      public static function transformDateTime($value, $format, $time = NULL) {
        $date = new \DateTime($value);
        $date->createFromFormat($format, $value);
        if ($time && $time !== EntityManager::EMPTYPROPERTYPLACEHOLDER) {
          $time_parts = explode(':', $time);
    Severity: Minor
    Found in src/Entity/Entity.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $time_parts is not named in camelCase.
    Open

      public static function transformDateTime($value, $format, $time = NULL) {
        $date = new \DateTime($value);
        $date->createFromFormat($format, $value);
        if ($time && $time !== EntityManager::EMPTYPROPERTYPLACEHOLDER) {
          $time_parts = explode(':', $time);
    Severity: Minor
    Found in src/Entity/Entity.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    The variable $time_parts is not named in camelCase.
    Open

      public static function transformDateTime($value, $format, $time = NULL) {
        $date = new \DateTime($value);
        $date->createFromFormat($format, $value);
        if ($time && $time !== EntityManager::EMPTYPROPERTYPLACEHOLDER) {
          $time_parts = explode(':', $time);
    Severity: Minor
    Found in src/Entity/Entity.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status