Showing 1,311 of 1,311 total issues
Identical blocks of code found in 2 locations. Consider refactoring. Open
function multipleContexts( selector, contexts, results ) {
var i = 0,
len = contexts.length;
for ( ; i < len; i++ ) {
Sizzle( selector, contexts[i], results );
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 58.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if ( window.ActiveXObject ) {
jQuery( window ).on( "unload", function() {
for ( var key in xhrCallbacks ) {
xhrCallbacks[ key ]();
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 58.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function _addBounds
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
_addBounds: function(v0, v1, v2, v3, coord, padding, min, max, roots) {
Function _addBounds
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
_addBounds: function(v0, v1, v2, v3, coord, padding, min, max, roots) {
Function read
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
read: function(list, start, options, length) {
if (this === Base) {
var value = this.peek(list, start);
list.__index++;
return value;
Function _hitTestSelf
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
_hitTestSelf: function _hitTestSelf(point, options) {
var hit = false;
if (this.hasStroke()) {
var type = this._type,
radius = this._radius,
Function get
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
fields[get] = function(_dontMerge) {
var owner = this._owner,
children = owner && owner._children,
value;
if (!children || children.length === 0 || _dontMerge
Function getTransform
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
function getTransform(matrix, coordinates, center) {
var attrs = new Base(),
trans = matrix.getTranslation();
if (coordinates) {
matrix = matrix.shiftless();
Function insertChildren
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
insertChildren: function(index, items, _preserve, _proto) {
var children = this._children;
if (children && items && items.length > 0) {
items = Array.prototype.slice.apply(items);
for (var i = items.length - 1; i >= 0; i--) {
Function removeSegments
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
removeSegments: function(from, to, _includeCurves) {
from = from || 0;
to = Base.pick(to, this._segments.length);
var segments = this._segments,
curves = this._curves,
Function _hitTestSelf
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
_hitTestSelf: function _hitTestSelf(point, options) {
var hit = false;
if (this.hasStroke()) {
var type = this._type,
radius = this._radius,
Function removeSegments
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
removeSegments: function(from, to, _includeCurves) {
from = from || 0;
to = Base.pick(to, this._segments.length);
var segments = this._segments,
curves = this._curves,
Function read
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
read: function(list, start, options, length) {
if (this === Base) {
var value = this.peek(list, start);
list.__index++;
return value;
Function get
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
fields[get] = function(_dontMerge) {
var owner = this._owner,
children = owner && owner._children,
value;
if (!children || children.length === 0 || _dontMerge
Function insertChildren
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
insertChildren: function(index, items, _preserve, _proto) {
var children = this._children;
if (children && items && items.length > 0) {
items = Array.prototype.slice.apply(items);
for (var i = items.length - 1; i >= 0; i--) {
Function getTransform
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
function getTransform(matrix, coordinates, center) {
var attrs = new Base(),
trans = matrix.getTranslation();
if (coordinates) {
matrix = matrix.shiftless();
Function finish
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
finish: function( type ) {
if ( type !== false ) {
type = type || "fx";
}
return this.each(function() {
Function finish
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
finish: function( type ) {
if ( type !== false ) {
type = type || "fx";
}
return this.each(function() {
Function TabsetCtrl
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
.controller('TabsetController', ['$scope', function TabsetCtrl($scope) {
var ctrl = this,
tabs = ctrl.tabs = $scope.tabs = [];
ctrl.select = function(selectedTab) {
Function TabsetCtrl
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
.controller('TabsetController', ['$scope', function TabsetCtrl($scope) {
var ctrl = this,
tabs = ctrl.tabs = $scope.tabs = [];
ctrl.select = function(selectedTab) {