Sign upLogin

JoryHogeveen/view-admin-as

View on GitHub
Star

Showing 56 of 72 total issues

File class-role-defaults.php has 1324 lines of code (exceeds 1000 allowed). Consider refactoring.
Open

<?php
/**
 * View Admin As - Role Defaults Module
 *
 * @author  Jory Hogeveen <info@keraweb.nl>
Severity: Major
Found in modules/class-role-defaults.php - About 1 day to fix

    File class-role-manager.php has 1170 lines of code (exceeds 1000 allowed). Consider refactoring.
    Open

    <?php
/**
 * View Admin As - Role Manager Module
 *
 * @author  Jory Hogeveen <info@keraweb.nl>
    Severity: Major
    Found in modules/class-role-manager.php - About 6 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              $admin_bar->add_node( array(
            'id'     => $root . '-export-roles-export',
            'parent' => $root . '-export',
            'title'  => VAA_View_Admin_As_Form::do_button( array(
                'name'    => $root . '-export-roles-export',
      Severity: Major
      Found in modules/class-role-manager.php and 1 other location - About 4 hrs to fix
      modules/class-role-defaults.php on lines 1720..1740

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 169.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  $admin_bar->add_node( array(
                'id'     => $root . '-export-roles-export',
                'parent' => $root . '-export',
                'title'  => VAA_View_Admin_As_Form::do_button( array(
                    'name'    => $root . '-export-roles-export',
      Severity: Major
      Found in modules/class-role-defaults.php and 1 other location - About 4 hrs to fix
      modules/class-role-manager.php on lines 1181..1201

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 169.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  $admin_bar->add_node( array(
                'id'     => $root . '-import-roles-file',
                'parent' => $root . '-import',
                'title'  => VAA_View_Admin_As_Form::do_input( array(
                    'name'    => $root . '-import-roles-file',
      Severity: Major
      Found in modules/class-role-defaults.php and 1 other location - About 3 hrs to fix
      modules/class-role-manager.php on lines 1234..1255

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 144.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              $admin_bar->add_node( array(
            'id'     => $root . '-import-roles-file',
            'parent' => $root . '-import',
            'title'  => VAA_View_Admin_As_Form::do_input( array(
                'name'    => $root . '-import-roles-file',
      Severity: Major
      Found in modules/class-role-manager.php and 1 other location - About 3 hrs to fix
      modules/class-role-defaults.php on lines 1773..1794

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 144.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function has a complexity of 13.
      Open

                      function( response ) {
      Severity: Minor
      Found in assets/js/view-admin-as.js by eslint

      Limit Cyclomatic Complexity (complexity)

      Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

      function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

      Rule Details

      This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

      Examples of incorrect code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

      Examples of correct code for a maximum of 2:

      /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

      Options

      Optionally, you may specify a max object property:

      "complexity": ["error", 2]

      is equivalent to

      "complexity": ["error", { "max": 2 }]

      Deprecated: the object property maximum is deprecated. Please use the property max instead.

      When Not To Use It

      If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

      Further Reading

      Related Rules

      • [max-depth](max-depth.md)
      • [max-len](max-len.md)
      • [max-nested-callbacks](max-nested-callbacks.md)
      • [max-params](max-params.md)
      • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

      Avoid using undefined variables such as '$data_languages' which will lead to PHP notices.
      Open

              $this->set_data( $data_languages );
      Severity: Minor
      Found in modules/class-languages.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$data_languages' which will lead to PHP notices.
      Open

              $data_languages['en_US'] = 'English';
      Severity: Minor
      Found in modules/class-languages.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$all_roles_option' which will lead to PHP notices.
      Open

              array_splice( $role_export_options, 1, 0, $all_roles_option );
      Severity: Minor
      Found in modules/class-role-manager.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$data_languages' which will lead to PHP notices.
      Open

                      $data_languages[ $locale ] = $languages[ $locale ];
      Severity: Minor
      Found in modules/class-languages.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$all_roles_option' which will lead to PHP notices.
      Open

              $all_roles_option['__all__'] = array(
      Severity: Minor
      Found in modules/class-role-manager.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$data_languages' which will lead to PHP notices.
      Open

                  $this->store->update_optionData( $data_languages, $this->optionKey, true );
      Severity: Minor
      Found in modules/class-languages.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Method name "_get_filters" should not be prefixed with an underscore to indicate visibility
      Open

          public function _get_filters( $keys = null, $objects = false ) {
      Severity: Minor
      Found in includes/class-hooks.php by phpcodesniffer

      All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$notice'.
      Open

                      echo '<div class="' . $notice['type'] . ' notice is-dismissible"><p>' . $notice['message'] . '</p></div>';
      Severity: Minor
      Found in includes/class-vaa.php by phpcodesniffer

      Overriding WordPress globals is prohibited. Found assignment to $super_admins
      Open

                  $super_admins = get_super_admins();
      Severity: Minor
      Found in includes/class-view.php by phpcodesniffer

      Found precision alignment of 1 spaces.
      Open

                               */
      Severity: Minor
      Found in modules/class-role-defaults.php by phpcodesniffer

      Method name "_filter_get_user_capabilities" should not be prefixed with an underscore to indicate visibility
      Open

          public function _filter_get_user_capabilities( $null, $user_id, $meta_key ) {
      Severity: Minor
      Found in modules/class-users.php by phpcodesniffer

      Method name "_validate_priority" should not be prefixed with an underscore to indicate visibility
      Open

          protected function _validate_priority( $hooks, $hook, $callback, $priority ) {
      Severity: Minor
      Found in includes/class-hooks.php by phpcodesniffer

      Expected 1 space after comma in function call; 5 found
      Open

          define( 'VIEW_ADMIN_AS_DOMAIN',     'view-admin-as' );
      Severity: Minor
      Found in view-admin-as.php by phpcodesniffer
      Severity
      Category
      Status
      Source
      Language