Sign upLogin

KarrLab/wc_sim

View on GitHub
Star
wc_sim/utils/time_ordered_list.py

Summary

Maintainability
C
7 hrs
Test Coverage
D
67%

File time_ordered_list.py has 392 lines of code (exceeds 250 allowed). Consider refactoring.
Open

""" Doubly-linked list ordered by time

:Author: Arthur Goldberg <Arthur.Goldberg@mssm.edu>
:Date: 2019-11-20
:Copyright: 2019, Karr Lab
Severity: Minor
Found in wc_sim/utils/time_ordered_list.py - About 5 hrs to fix

    Function slope has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def slope(self, time, left_node=None):
        """ Get the population slope at time `time`

        Args:
            time (:obj:`Rational`): time value
    Severity: Minor
    Found in wc_sim/utils/time_ordered_list.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return self._slope_between_node_pair(left_node)
    Severity: Major
    Found in wc_sim/utils/time_ordered_list.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return (next_node._data.pop_before - prev_node._data.pop_after) / \
      Severity: Major
      Found in wc_sim/utils/time_ordered_list.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status