Kinvey/swift-sdk

View on GitHub
Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift

Summary

Maintainability
D
1 day
Test Coverage

File MongoDBPredicateAdaptor.swift has 389 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Foundation

#if canImport(MapKit)
    import MapKit
#endif

    Function transform has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private func transform(constant: Any?, modifyingOperator `operator`: inout MongoDBOperator) -> Any? {
            
            if constant == nil || constant is NSNull {
                return NSNull()
            } else if constant is String {

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function replacementPredicate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private func replacementPredicate(forBetweenPredicate predicate: NSComparisonPredicate) -> NSPredicate? {
            let rightExpression = predicate.rightExpression
            
            guard let bounds = rightExpression.constantValue as? [Any], bounds.count == 2 else {
                return nil

      Function transform has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private func transform(constant: Any?, modifyingOperator `operator`: inout MongoDBOperator) -> Any? {
              
              if constant == nil || constant is NSNull {
                  return NSNull()
              } else if constant is String {

        Function transform has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private func transform(comparisonPredicate predicate: NSComparisonPredicate) -> [String : Any]? {
                var result: [String : Any]? = nil
                if predicate.leftExpression.expressionType == .function ||
                    predicate.rightExpression.expressionType == .function
                {

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function ensureKeyPathExpressionsContainJSThis has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private func ensureKeyPathExpressionsContainJSThis(inExpression expression: NSExpression) -> NSExpression {
                switch expression.expressionType {
                case .keyPath:
                    return NSExpression(forKeyPath: "this.\(expression.keyPath)")
                case .function:

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                return nil

          Avoid too many return statements within this function.
          Open

                      return transform(geoShape: shape)

            Function replacementPredicate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private func replacementPredicate(forComparisonPredicate predicate: NSComparisonPredicate) -> NSPredicate? {
                    switch predicate.predicateOperatorType {
                    case .between:
                        return replacementPredicate(forBetweenPredicate: predicate)
                    case .beginsWith:

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                private func replacementPredicate(forEndsWithPredicate predicate: NSComparisonPredicate) -> NSPredicate? {
                    if let constantValue = predicate.rightExpression.constantValue {
                        let endsWithRegex = ".*\(constantValue)"
                        return replacementPredicate(
                            forComparisonPredicate: predicate,
            Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift on lines 195..204
            Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift on lines 217..226
            Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift on lines 228..237

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                private func replacementPredicate(forContainsPredicate predicate: NSComparisonPredicate) -> NSPredicate? {
                    if let constantValue = predicate.rightExpression.constantValue {
                        let containsRegex = ".*\(constantValue).*"
                        return replacementPredicate(
                            forComparisonPredicate: predicate,
            Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift on lines 195..204
            Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift on lines 206..215
            Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift on lines 228..237

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                private func replacementPredicate(forLikePredicate predicate: NSComparisonPredicate) -> NSPredicate? {
                    if let constantValue = predicate.rightExpression.constantValue {
                        let likeRegex = "/(\(constantValue))/"
                        return replacementPredicate(
                            forComparisonPredicate: predicate,
            Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift on lines 195..204
            Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift on lines 206..215
            Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift on lines 217..226

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                private func replacementPredicate(forBeginsWithPredicate predicate: NSComparisonPredicate) -> NSPredicate? {
                    if let constantValue = predicate.rightExpression.constantValue {
                        let beginsWithRegex = "^\(constantValue)"
                        return replacementPredicate(
                            forComparisonPredicate: predicate,
            Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift on lines 206..215
            Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift on lines 217..226
            Carthage/Checkouts/NSPredicate-MongoDB-Adaptor/Sources/MongoDBPredicateAdaptor/MongoDBPredicateAdaptor.swift on lines 228..237

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status