Sign upLogin

Kinvey/swift-sdk

View on GitHub
Star
Kinvey/Kinvey/HttpRequest.swift

Summary

Maintainability
D
2 days
Test Coverage

File HttpRequest.swift has 496 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Foundation

#if os(iOS) || os(tvOS)
    import UIKit
#elseif os(watchOS)
Severity: Minor
Found in Kinvey/Kinvey/HttpRequest.swift - About 7 hrs to fix

    Function refreshToken has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        private func refreshToken(
        user: User,
        urlSession: URLSession,
        data: Data?,
        response: URLResponse?,
    Severity: Minor
    Found in Kinvey/Kinvey/HttpRequest.swift - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function refreshToken has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private func refreshToken(
        user: User,
        urlSession: URLSession,
        data: Data?,
        response: URLResponse?,
    Severity: Minor
    Found in Kinvey/Kinvey/HttpRequest.swift - About 2 hrs to fix

      Function handleResponse has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private func handleResponse(
        retry: Bool,
        urlSession: URLSession,
        data: Data?,
        response: URLResponse?,
      Severity: Minor
      Found in Kinvey/Kinvey/HttpRequest.swift - About 1 hr to fix

        Function prepareRequest has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            func prepareRequest() {
        for header in defaultHeaders {
            request.setValue(header.value, forHTTPHeaderField: header.name)
        }
        setAuthorization()
        Severity: Minor
        Found in Kinvey/Kinvey/HttpRequest.swift - About 1 hr to fix

          Function handleResponse has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  retry: Bool,
        urlSession: URLSession,
        data: Data?,
        response: URLResponse?,
        error: Swift.Error?,
          Severity: Minor
          Found in Kinvey/Kinvey/HttpRequest.swift - About 45 mins to fix

            Function refreshToken has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    user: User,
        urlSession: URLSession,
        data: Data?,
        response: URLResponse?,
        error: Swift.Error?,
            Severity: Minor
            Found in Kinvey/Kinvey/HttpRequest.swift - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private func handleResponse(
        retry: Bool,
        urlSession: URLSession,
        data: Data?,
        response: URLResponse?,
              Severity: Minor
              Found in Kinvey/Kinvey/HttpRequest.swift and 1 other location - About 45 mins to fix
              Kinvey/Kinvey/HttpRequest.swift on lines 524..582

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private func refreshToken(
        user: User,
        urlSession: URLSession,
        data: Data?,
        response: URLResponse?,
              Severity: Minor
              Found in Kinvey/Kinvey/HttpRequest.swift and 1 other location - About 45 mins to fix
              Kinvey/Kinvey/HttpRequest.swift on lines 486..522

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 54.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  internal var cancelled: Bool {
        return task?.state == .canceling || (task?.error as NSError?)?.code == NSURLErrorCancelled
    }
              Severity: Minor
              Found in Kinvey/Kinvey/HttpRequest.swift and 1 other location - About 35 mins to fix
              Kinvey/Kinvey/URLSessionTaskRequest.swift on lines 22..24

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 44.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status