File MIC.swift
has 528 lines of code (exceeds 250 allowed). Consider refactoring. Open
import Foundation
import PromiseKit
class URLSessionDelegateAdapter : NSObject, URLSessionTaskDelegate {
Function oauthGrantAuthenticate
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
private class func oauthGrantAuthenticate<U: User>(
redirectURI: URL,
username: String,
password: String,
options: Options?,
Function login
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
@discardableResult
class func login<U: User>(
username: String,
password: String,
options: Options? = nil,
Function login
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
@discardableResult
class func login<U: User>(
redirectURI: URL,
username: String,
password: String,
Function parseCode
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
class func parseCode(redirectURI: URL, url: URL) -> Swift.Result<String, Swift.Error> {
guard redirectURI.scheme?.lowercased() == url.scheme?.lowercased(),
redirectURI.host?.lowercased() == url.host?.lowercased(),
let urlComponents = URLComponents(url: url, resolvingAgainstBaseURL: false),
let queryItems = urlComponents.queryItems
Function login
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
@discardableResult
class func login<U: User>(
redirectURI: URL,
code: String,
options: Options? = nil,
Function oauthGrantAuthenticate
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
private class func oauthGrantAuthenticate<U: User>(
redirectURI: URL,
username: String,
password: String,
options: Options?,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function oauthGrantAuthenticate
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
redirectURI: URL,
username: String,
password: String,
options: Options?,
requests: MultiRequest<Swift.Result<U, Swift.Error>>,
Function parseCode
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
class func parseCode(redirectURI: URL, url: URL) -> Swift.Result<String, Swift.Error> {
guard redirectURI.scheme?.lowercased() == url.scheme?.lowercased(),
redirectURI.host?.lowercased() == url.host?.lowercased(),
let urlComponents = URLComponents(url: url, resolvingAgainstBaseURL: false),
let queryItems = urlComponents.queryItems
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function login
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
redirectURI: URL,
code: String,
userType: U.Type,
options: Options? = nil,
completionHandler: ((Swift.Result<U, Swift.Error>) -> Void)? = nil
Function login
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
redirectURI: URL,
username: String,
password: String,
options: Options? = nil,
completionHandler: ((Swift.Result<U, Swift.Error>) -> Void)? = nil
Function urlSession
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
func urlSession(_ session: URLSession, task: URLSessionTask, willPerformHTTPRedirection response: HTTPURLResponse, newRequest request: URLRequest, completionHandler: @escaping (URLRequest?) -> Void) {
Function webView
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
func webView(_ webView: WKWebView, decidePolicyFor navigationAction: WKNavigationAction, decisionHandler: @escaping (WKNavigationActionPolicy) -> Void) {
var navigationActionPolicy: WKNavigationActionPolicy = .allow
if let url = navigationAction.request.url {
switch MIC.parseCode(redirectURI: redirectURI, url: url) {
case .success(let code):
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Identical blocks of code found in 2 locations. Consider refactoring. Open
//
// MIC.swift
// Kinvey
//
// Created by Victor Hugo on 2017-01-18.
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 68.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
) { result in
switch result {
case .success(let user):
resolver.fulfill(user as! U)
case .failure(let error):
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 57.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76