Sign upLogin

Kinvey/swift-sdk

View on GitHub
Star
Kinvey/Kinvey/SaveMultiOperation.swift

Summary

Maintainability
F
3 days
Test Coverage

Function saveSingleRequest has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    private func saveSingleRequest(newItems: AnyRandomAccessCollection<T>, requests: MultiRequest<ResultType>) -> Promise<ResultType> {
        let objectIds = newItems.map({ $0.entityId })
        let request = client.networkRequestFactory.appData.buildAppDataSave(
            newItems,
            options: options,
Severity: Minor
Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function executeNetwork has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    func executeNetwork(_ completionHandler: CompletionHandler?) -> AnyRequest<ResultType> {
        guard client.activeUser != nil else {
            let result: Swift.Result<MultiSaveResultTuple<T>, Swift.Error> = .failure(Error.noActiveUser)
            completionHandler?(result)
            return AnyRequest(result)
Severity: Minor
Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File SaveMultiOperation.swift has 309 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Foundation
import PromiseKit

internal let maxSizePerRequest = 100
Severity: Minor
Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 3 hrs to fix

    Function saveSingleRequest has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private func saveSingleRequest(newItems: AnyRandomAccessCollection<T>, requests: MultiRequest<ResultType>) -> Promise<ResultType> {
        let objectIds = newItems.map({ $0.entityId })
        let request = client.networkRequestFactory.appData.buildAppDataSave(
            newItems,
            options: options,
    Severity: Major
    Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 2 hrs to fix

      Function executeNetwork has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          func executeNetwork(_ completionHandler: CompletionHandler?) -> AnyRequest<ResultType> {
        guard client.activeUser != nil else {
            let result: Swift.Result<MultiSaveResultTuple<T>, Swift.Error> = .failure(Error.noActiveUser)
            completionHandler?(result)
            return AnyRequest(result)
      Severity: Major
      Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 2 hrs to fix

        Function saveMultiRequests has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private func saveMultiRequests(newItems: AnyRandomAccessCollection<T>, requests: MultiRequest<ResultType>) -> Promise<ResultType> {
        var offsetIterator = stride(from: 0, to: persistable.count, by: maxSizePerRequest).makeIterator()
        let promisesIterator = AnyIterator<Guarantee<ResultType>> {
            guard let offset = offsetIterator.next() else {
                return nil
        Severity: Minor
        Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 1 hr to fix

          Function saveMultiRequests has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              private func saveMultiRequests(newItems: AnyRandomAccessCollection<T>, requests: MultiRequest<ResultType>) -> Promise<ResultType> {
        var offsetIterator = stride(from: 0, to: persistable.count, by: maxSizePerRequest).makeIterator()
        let promisesIterator = AnyIterator<Guarantee<ResultType>> {
            guard let offset = offsetIterator.next() else {
                return nil
          Severity: Minor
          Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function executeLocal has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              func executeLocal(_ completionHandler: CompletionHandler?) -> AnyRequest<ResultType> {
        guard self.persistable.count > 0 else {
            return requestBodyCannotBeAnEmptyArrayError(completionHandler)
        }
        let request = LocalRequest<Swift.Result<MultiSaveResultTuple<T>, Swift.Error>>()
          Severity: Minor
          Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 1 hr to fix

            Function executeLocal has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                func executeLocal(_ completionHandler: CompletionHandler?) -> AnyRequest<ResultType> {
        guard self.persistable.count > 0 else {
            return requestBodyCannotBeAnEmptyArrayError(completionHandler)
        }
        let request = LocalRequest<Swift.Result<MultiSaveResultTuple<T>, Swift.Error>>()
            Severity: Minor
            Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                    return AnyRequest(requests)
            Severity: Major
            Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                                          return Error.unknownJsonError(httpResponse: response.httpResponse, data: data, json: json)
              Severity: Major
              Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                        return MultiSaveError(
                            index: index,
                            error: error,
                            serverDescription: description,
                            serverDebug: debug
                Severity: Major
                Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return .success((entities: AnyRandomAccessCollection(entities), errors: AnyRandomAccessCollection(errors)))
                  Severity: Major
                  Found in Kinvey/Kinvey/SaveMultiOperation.swift - About 30 mins to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        private func saveSingleRequest(newItems: AnyRandomAccessCollection<T>, requests: MultiRequest<ResultType>) -> Promise<ResultType> {
        let objectIds = newItems.map({ $0.entityId })
        let request = client.networkRequestFactory.appData.buildAppDataSave(
            newItems,
            options: options,
                    Severity: Minor
                    Found in Kinvey/Kinvey/SaveMultiOperation.swift and 1 other location - About 30 mins to fix
                    Kinvey/Kinvey/SaveMultiOperation.swift on lines 272..322

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 41.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        private func saveMultiRequests(newItems: AnyRandomAccessCollection<T>, requests: MultiRequest<ResultType>) -> Promise<ResultType> {
        var offsetIterator = stride(from: 0, to: persistable.count, by: maxSizePerRequest).makeIterator()
        let promisesIterator = AnyIterator<Guarantee<ResultType>> {
            guard let offset = offsetIterator.next() else {
                return nil
                    Severity: Minor
                    Found in Kinvey/Kinvey/SaveMultiOperation.swift and 1 other location - About 30 mins to fix
                    Kinvey/Kinvey/SaveMultiOperation.swift on lines 203..270

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 41.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status