Sign upLogin

Kinvey/swift-sdk

View on GitHub
Star
Kinvey/Kinvey/Sync.swift

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    func save<C>(pendingOperations: C) where C : Collection, C.Element == PendingOperation {
        _savePendingOperations(AnyCollection(pendingOperations))
    }
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift and 1 other location - About 45 mins to fix
Kinvey/Kinvey/Sync.swift on lines 92..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    func remove<C>(requestIds: C) where C : Collection, C.Element == String {
        _removePendingOperations(AnyCollection(requestIds))
    }
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift and 1 other location - About 45 mins to fix
Kinvey/Kinvey/Sync.swift on lines 84..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Global Constant should be either lowerCamelCase or UpperCamelCase
Open

    private let _pendingOperationsCount: () -> Int
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

constant-naming

Global constants should follow either UpperCamelCase or lowerCamelCase naming conventions. Local constants should follow lowerCamelCase naming conventions.

Preferred

let MaxHeight = 42
let maxHeight = 42

Not Preferred

let max_height = 42

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Global Constant should be either lowerCamelCase or UpperCamelCase
Open

    private let _removePendingOperation: (PendingOperation) -> Void
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

constant-naming

Global constants should follow either UpperCamelCase or lowerCamelCase naming conventions. Local constants should follow lowerCamelCase naming conventions.

Preferred

let MaxHeight = 42
let maxHeight = 42

Not Preferred

let max_height = 42

Single-line comment should start with whitespace
Open

    //Create
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

comment-whitespace

Prefer at least one whitespace character after a comment opening symbol (//, ///, /*, or /**) and at least one whitespace character before a comment closing symbol (*/).

Preferred

// This is a comment

/// This is a documentation comment

/* This is a
multi-line comment */

/* This is a
multi-line comment
*/

/** This is a
documentation multi-line
comment
*/

Not Preferred

//This is a comment

///This is a documentation comment

/*This is a
multi-line comment*/

/**This is a multi-line
documentation comment */

Single-line comment should start with whitespace
Open

    //Read
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

comment-whitespace

Prefer at least one whitespace character after a comment opening symbol (//, ///, /*, or /**) and at least one whitespace character before a comment closing symbol (*/).

Preferred

// This is a comment

/// This is a documentation comment

/* This is a
multi-line comment */

/* This is a
multi-line comment
*/

/** This is a
documentation multi-line
comment
*/

Not Preferred

//This is a comment

///This is a documentation comment

/*This is a
multi-line comment*/

/**This is a multi-line
documentation comment */

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Global Constant should be either lowerCamelCase or UpperCamelCase
Open

    private let _createPendingOperation: (URLRequest, String?) -> PendingOperation
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

constant-naming

Global constants should follow either UpperCamelCase or lowerCamelCase naming conventions. Local constants should follow lowerCamelCase naming conventions.

Preferred

let MaxHeight = 42
let maxHeight = 42

Not Preferred

let max_height = 42

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Single-line comment should start with whitespace
Open

    //Update
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

comment-whitespace

Prefer at least one whitespace character after a comment opening symbol (//, ///, /*, or /**) and at least one whitespace character before a comment closing symbol (*/).

Preferred

// This is a comment

/// This is a documentation comment

/* This is a
multi-line comment */

/* This is a
multi-line comment
*/

/** This is a
documentation multi-line
comment
*/

Not Preferred

//This is a comment

///This is a documentation comment

/*This is a
multi-line comment*/

/**This is a multi-line
documentation comment */

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Single-line comment should start with whitespace
Open

    //Update
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

comment-whitespace

Prefer at least one whitespace character after a comment opening symbol (//, ///, /*, or /**) and at least one whitespace character before a comment closing symbol (*/).

Preferred

// This is a comment

/// This is a documentation comment

/* This is a
multi-line comment */

/* This is a
multi-line comment
*/

/** This is a
documentation multi-line
comment
*/

Not Preferred

//This is a comment

///This is a documentation comment

/*This is a
multi-line comment*/

/**This is a multi-line
documentation comment */

Global Constant should be either lowerCamelCase or UpperCamelCase
Open

    private let _savePendingOperation: (PendingOperation) -> Void
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

constant-naming

Global constants should follow either UpperCamelCase or lowerCamelCase naming conventions. Local constants should follow lowerCamelCase naming conventions.

Preferred

let MaxHeight = 42
let maxHeight = 42

Not Preferred

let max_height = 42

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Global Constant should be either lowerCamelCase or UpperCamelCase
Open

    private let _savePendingOperations: (AnyCollection<PendingOperation>) -> Void
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

constant-naming

Global constants should follow either UpperCamelCase or lowerCamelCase naming conventions. Local constants should follow lowerCamelCase naming conventions.

Preferred

let MaxHeight = 42
let maxHeight = 42

Not Preferred

let max_height = 42

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Global Constant should be either lowerCamelCase or UpperCamelCase
Open

    private let _removeAllPendingOperations: (String?, [String]?) -> Int
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

constant-naming

Global constants should follow either UpperCamelCase or lowerCamelCase naming conventions. Local constants should follow lowerCamelCase naming conventions.

Preferred

let MaxHeight = 42
let maxHeight = 42

Not Preferred

let max_height = 42

Single-line comment should start with whitespace
Open

    //Count
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

comment-whitespace

Prefer at least one whitespace character after a comment opening symbol (//, ///, /*, or /**) and at least one whitespace character before a comment closing symbol (*/).

Preferred

// This is a comment

/// This is a documentation comment

/* This is a
multi-line comment */

/* This is a
multi-line comment
*/

/** This is a
documentation multi-line
comment
*/

Not Preferred

//This is a comment

///This is a documentation comment

/*This is a
multi-line comment*/

/**This is a multi-line
documentation comment */

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Global Constant should be either lowerCamelCase or UpperCamelCase
Open

    private let _removePendingOperations: (AnyCollection<String>) -> Void
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

constant-naming

Global constants should follow either UpperCamelCase or lowerCamelCase naming conventions. Local constants should follow lowerCamelCase naming conventions.

Preferred

let MaxHeight = 42
let maxHeight = 42

Not Preferred

let max_height = 42

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Global Constant should be either lowerCamelCase or UpperCamelCase
Open

    private let _pendingOperations: (Bool) -> AnyRandomAccessCollection<PendingOperation>
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

constant-naming

Global constants should follow either UpperCamelCase or lowerCamelCase naming conventions. Local constants should follow lowerCamelCase naming conventions.

Preferred

let MaxHeight = 42
let maxHeight = 42

Not Preferred

let max_height = 42

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Line should not have any trailing whitespace
Open
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

trailing-whitespace

Flag whitespace after the last non-whitespace character on each line until the newline.

Preferred

let number = 42¬

Not Preferred

let number = 42••¬

Single-line comment should start with whitespace
Open

    //Delete
Severity: Minor
Found in Kinvey/Kinvey/Sync.swift by tailor

comment-whitespace

Prefer at least one whitespace character after a comment opening symbol (//, ///, /*, or /**) and at least one whitespace character before a comment closing symbol (*/).

Preferred

// This is a comment

/// This is a documentation comment

/* This is a
multi-line comment */

/* This is a
multi-line comment
*/

/** This is a
documentation multi-line
comment
*/

Not Preferred

//This is a comment

///This is a documentation comment

/*This is a
multi-line comment*/

/**This is a multi-line
documentation comment */

There are no issues that match your filters.

Category
Status