Sign upLogin

Kuangcp/JavaBase

View on GitHub
Star
algorithms/src/main/java/com/github/kuangcp/sort/Quick.java

Summary

Maintainability
C
1 day
Test Coverage

Method quickSort has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  public <T extends Comparable<? super T>> T[] quickSort(T[] data, int start, int end) {
    int low = start + 1, high = end;
    T key = data[start];

    if (start >= end) {
Severity: Minor
Found in algorithms/src/main/java/com/github/kuangcp/sort/Quick.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sortData has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public void sortData(int[] data, int low, int high) {
      int lowIndex = low;
      int highIndex = high;
      int index = data[low];
Severity: Minor
Found in algorithms/src/main/java/com/github/kuangcp/sort/Quick.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sortData has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public void sortData(int[] data, int low, int high) {
      int lowIndex = low;
      int highIndex = high;
      int index = data[low];
Severity: Minor
Found in algorithms/src/main/java/com/github/kuangcp/sort/Quick.java - About 1 hr to fix

    Method quickSort has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public <T extends Comparable<? super T>> T[] quickSort(T[] data, int start, int end) {
    int low = start + 1, high = end;
    T key = data[start];

    if (start >= end) {
    Severity: Minor
    Found in algorithms/src/main/java/com/github/kuangcp/sort/Quick.java - About 1 hr to fix

      Method sortData has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          @Override
    public void sortData(int[] data, int low, int high) {
      if (low >= high) {
        return;
      }
      Severity: Minor
      Found in algorithms/src/main/java/com/github/kuangcp/sort/Quick.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (lowIndex < highIndex) {
          int temp = data[highIndex];
          data[highIndex] = data[lowIndex];
          data[lowIndex] = temp;
          lowIndex++;
      Severity: Minor
      Found in algorithms/src/main/java/com/github/kuangcp/sort/Quick.java and 1 other location - About 45 mins to fix
      algorithms/src/main/java/com/github/kuangcp/sort/Quick.java on lines 91..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (lowIndex < highIndex) {
          int temp = data[highIndex];
          data[highIndex] = data[lowIndex];
          data[lowIndex] = temp;
          highIndex--;
      Severity: Minor
      Found in algorithms/src/main/java/com/github/kuangcp/sort/Quick.java and 1 other location - About 45 mins to fix
      algorithms/src/main/java/com/github/kuangcp/sort/Quick.java on lines 81..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status