Sign upLogin

Kuangcp/JavaBase

View on GitHub
Star
class/src/main/java/com/github/kuangcp/generic/sample/SampleUtil.java

Summary

Maintainability
A
2 hrs
Test Coverage

Method sampleWithNoRepeated has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  public static <T> List<T> sampleWithNoRepeated(Map<T, Integer> rateMap, int count) {
    List<T> result = new ArrayList<>();
    for (int i = 0; i < count; i++) {
      int total = 0;
      for (Entry<T, Integer> entry : rateMap.entrySet()) {
Severity: Minor
Found in class/src/main/java/com/github/kuangcp/generic/sample/SampleUtil.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sampleWithNoRepeatedWithPutBack has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  public static <T> List<T> sampleWithNoRepeatedWithPutBack(Map<T, Integer> rateMap, int count) {
    List<T> result = new ArrayList<>();
    int total = 0;
    for (Entry<T, Integer> entry : rateMap.entrySet()) {
      total += entry.getValue();
Severity: Minor
Found in class/src/main/java/com/github/kuangcp/generic/sample/SampleUtil.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method calculRate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  private static Integer calculRate(Map<Integer, Integer> map) {
    if (null == map || map.size() == 0) {
      return 0;
    }
    int weightSum = 0;
Severity: Minor
Found in class/src/main/java/com/github/kuangcp/generic/sample/SampleUtil.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status