Sign upLogin

Kuangcp/JavaBase

View on GitHub
Star
gui/src/main/java/com/github/kuangcp/tank/util/Saved.java

Summary

Maintainability
D
2 days
Test Coverage

Method readAll has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public void readAll() {
        InputStream input = null;
        BufferedReader br = null;
        InputStreamReader ids = null;
        try {
Severity: Minor
Found in gui/src/main/java/com/github/kuangcp/tank/util/Saved.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method savedAll has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public void savedAll() {
        BufferedWriter bw = null;
        OutputStream out = null;
        OutputStreamWriter os = null;
Severity: Minor
Found in gui/src/main/java/com/github/kuangcp/tank/util/Saved.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method saveDataBase has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public void saveDataBase() {
        PreparedStatement ps = null;
        Connection cn = null;
        ResultSet rs = null;
Severity: Minor
Found in gui/src/main/java/com/github/kuangcp/tank/util/Saved.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method readAll has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void readAll() {
        InputStream input = null;
        BufferedReader br = null;
        InputStreamReader ids = null;
        try {
Severity: Major
Found in gui/src/main/java/com/github/kuangcp/tank/util/Saved.java - About 2 hrs to fix

    File Saved.java has 255 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package com.github.kuangcp.tank.util;

import com.github.kuangcp.tank.domain.Brick;
import com.github.kuangcp.tank.domain.EnemyTank;
import com.github.kuangcp.tank.domain.Hero;
    Severity: Minor
    Found in gui/src/main/java/com/github/kuangcp/tank/util/Saved.java - About 2 hrs to fix

      Method savedAll has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void savedAll() {
        BufferedWriter bw = null;
        OutputStream out = null;
        OutputStreamWriter os = null;
      Severity: Major
      Found in gui/src/main/java/com/github/kuangcp/tank/util/Saved.java - About 2 hrs to fix

        Method saveDataBase has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void saveDataBase() {
        PreparedStatement ps = null;
        Connection cn = null;
        ResultSet rs = null;
        Severity: Minor
        Found in gui/src/main/java/com/github/kuangcp/tank/util/Saved.java - About 2 hrs to fix

          Method readDataBase has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public void readDataBase() {
        PreparedStatement ps = null;
        Connection cn = null;
        ResultSet rs = null;
          Severity: Minor
          Found in gui/src/main/java/com/github/kuangcp/tank/util/Saved.java - About 1 hr to fix

            Method readDataBase has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public void readDataBase() {
        PreparedStatement ps = null;
        Connection cn = null;
        ResultSet rs = null;
            Severity: Minor
            Found in gui/src/main/java/com/github/kuangcp/tank/util/Saved.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        try {
                if (rs != null)
                    rs.close();
                if (ps != null)
                    ps.close();
            Severity: Minor
            Found in gui/src/main/java/com/github/kuangcp/tank/util/Saved.java and 1 other location - About 45 mins to fix
            network/src/main/java/com/github/kuangcp/bio/onechatone/ServerThread.java on lines 63..69

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    } finally {
            try {
                //后打开，先关闭
                input.close();
                ids.close();
            Severity: Minor
            Found in gui/src/main/java/com/github/kuangcp/tank/util/Saved.java and 1 other location - About 45 mins to fix
            gui/src/main/java/com/github/kuangcp/tank/util/Saved.java on lines 127..138

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    } finally {
            try {
                //后打开，先关闭
                out.close();
                os.close();
            Severity: Minor
            Found in gui/src/main/java/com/github/kuangcp/tank/util/Saved.java and 1 other location - About 45 mins to fix
            gui/src/main/java/com/github/kuangcp/tank/util/Saved.java on lines 221..233

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status