Sign upLogin

Kuangcp/JavaBase

View on GitHub
Star
network/src/main/java/com/github/kuangcp/nio/NIOServer.java

Summary

Maintainability
A
3 hrs
Test Coverage

Method readContent has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private void readContent(Selector selector, SelectionKey sk) throws IOException {
    SocketChannel sc = (SocketChannel) sk.channel();
    ByteBuffer buff = ByteBuffer.allocate(1024);

    StringBuilder content = new StringBuilder();
Severity: Minor
Found in network/src/main/java/com/github/kuangcp/nio/NIOServer.java - About 1 hr to fix

    Method readContent has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      private void readContent(Selector selector, SelectionKey sk) throws IOException {
    SocketChannel sc = (SocketChannel) sk.channel();
    ByteBuffer buff = ByteBuffer.allocate(1024);

    StringBuilder content = new StringBuilder();
    Severity: Minor
    Found in network/src/main/java/com/github/kuangcp/nio/NIOServer.java - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method start has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      private void start() throws Exception {
    Selector selector = Selector.open();

    //通过OPEN方法来打开一个未绑定的ServerSocketChannel 实例
    ServerSocketChannel server = ServerSocketChannel.open();
    Severity: Minor
    Found in network/src/main/java/com/github/kuangcp/nio/NIOServer.java - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status