Sign upLogin

KurtPattyn/kimbu

View on GitHub
Star

Showing 19 of 19 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Transport.prototype.unbind = function(consumeChannelName,
                                      dispatcherChannelName,
                                      bindingKey,
                                      callback) {
  assert.ok(util.isString(consumeChannelName), "Must provide a valid consume name.");
Severity: Major
Found in lib/transport.js and 1 other location - About 6 hrs to fix
lib/transport.js on lines 364..377

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 159.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Transport.prototype.bind = function(consumeChannelName,
                                    dispatcherChannelName,
                                    bindingKey,
                                    callback) {
  assert.ok(util.isString(consumeChannelName), "Must provide a valid consumer name.");
Severity: Major
Found in lib/transport.js and 1 other location - About 6 hrs to fix
lib/transport.js on lines 383..396

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 159.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File rabbitmqtransport.js has 309 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";

var MessageBusTransport = require("../transport");
var amqp = require("amqplib/callback_api");
var utils = require("../utils");
Severity: Minor
Found in lib/transportproviders/rabbitmqtransport.js - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    DispatchChannel.prototype.stop = function(callback) {
  const self = this;

  this._replyQueue.cancelConsume(function(err) {
    /* istanbul ignore if */
    Severity: Major
    Found in lib/dispatch_channel.js and 1 other location - About 2 hrs to fix
    lib/consume_channel.js on lines 144..155

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    ConsumeChannel.prototype.stop = function(cb) {
  const self = this;

  this._consumeQueue.cancelConsume(function(err) {
    /* istanbul ignore if */
    Severity: Major
    Found in lib/consume_channel.js and 1 other location - About 2 hrs to fix
    lib/dispatch_channel.js on lines 68..79

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function _doConnect has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    RabbitMQTransport.prototype._doConnect = function(callback) {
  //Transport.connect() guarantees that it doesn't call _doConnect if there is already
  //a valid connection
  assert(!this._connection);
  /** @constant
    Severity: Minor
    Found in lib/transportproviders/rabbitmqtransport.js - About 1 hr to fix

      Function start has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      ConsumeChannel.prototype.start = function(cb) {
  const self = this;

  this._consumeQueue.consume({}, function(msg, next) {
    const msgName = /*msg.options.type + ":" +*/ msg.name;
      Severity: Minor
      Found in lib/consume_channel.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        DispatchChannel.prototype.purge = function purge(callback) {
  assert(!callback || util.isFunction(callback), "callback must be a valid function");

  this._replyQueue.purge(callback);
};
        Severity: Major
        Found in lib/dispatch_channel.js and 1 other location - About 1 hr to fix
        lib/consume_channel.js on lines 197..201

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        ConsumeChannel.prototype.purge = function purge(callback) {
  assert(!callback || util.isFunction(callback), "callback must be a valid function");

  this._consumeQueue.purge(callback);
};
        Severity: Major
        Found in lib/consume_channel.js and 1 other location - About 1 hr to fix
        lib/dispatch_channel.js on lines 174..178

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function rabbitMQConnectCallback has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          amqp.connect(amqpURI, { noDelay: amqpNoDelay }, function rabbitMQConnectCallback(err, conn) {
// jscs:enable jsDoc
    if (err) {
      callback(err);
    } else {
        Severity: Minor
        Found in lib/transportproviders/rabbitmqtransport.js - About 1 hr to fix

          Function _rabbitMQMessageToMessage has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function _rabbitMQMessageToMessage(rmqMessage) {
  const options = _copyProperties(rmqMessage.properties, [
    "expiration",
    "correlationId",
    "replyTo",
          Severity: Minor
          Found in lib/transportproviders/rabbitmqtransport.js - About 1 hr to fix

            Function _doPublish has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            RabbitMQTransport.prototype._doPublish = function(exchangeName, msg, routingKey, callback) {
  const self = this;
  let rmqOptions = _messageOptionsToRabbitMQMessageOptions(msg);

  rmqOptions.headers.sequenceNumber = self._messageSequenceNumber++;
            Severity: Minor
            Found in lib/transportproviders/rabbitmqtransport.js - About 1 hr to fix

              Function Client has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function Client(clientName, transport, callback) {
  assert.ok(util.isString(clientName), "clientName must be a valid string");
  assert.ok(transport instanceof Transport);

  this._transport = transport;
              Severity: Minor
              Found in lib/client.js - About 1 hr to fix

                Function disconnect has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                Transport.prototype.disconnect = function(callback) {
  const self = this;

  if (this._isDisconnecting) {
    if (util.isFunction(callback)) {
                Severity: Minor
                Found in lib/transport.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function connect has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                Transport.prototype.connect = function(callback) {
  const self = this;

  if (this._isConnecting) {
    this.once("connected", function () {
                Severity: Minor
                Found in lib/transport.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _rabbitMQMessageToMessage has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                function _rabbitMQMessageToMessage(rmqMessage) {
  const options = _copyProperties(rmqMessage.properties, [
    "expiration",
    "correlationId",
    "replyTo",
                Severity: Minor
                Found in lib/transportproviders/rabbitmqtransport.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function connect has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                Transport.prototype.connect = function(callback) {
  const self = this;

  if (this._isConnecting) {
    this.once("connected", function () {
                Severity: Minor
                Found in lib/transport.js - About 1 hr to fix

                  Function _doConnect has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                  RabbitMQTransport.prototype._doConnect = function(callback) {
  //Transport.connect() guarantees that it doesn't call _doConnect if there is already
  //a valid connection
  assert(!this._connection);
  /** @constant
                  Severity: Minor
                  Found in lib/transportproviders/rabbitmqtransport.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _removeSIGINTHandler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function _removeSIGINTHandler(handler) {
  /* istanbul ignore else */
  if (handler) {
    var listenerCount = 0;
                  Severity: Minor
                  Found in lib/transportproviders/rabbitmqtransport.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language