KurtPattyn/kimbu

View on GitHub

Showing 13 of 19 total issues

File rabbitmqtransport.js has 309 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";

var MessageBusTransport = require("../transport");
var amqp = require("amqplib/callback_api");
var utils = require("../utils");
Severity: Minor
Found in lib/transportproviders/rabbitmqtransport.js - About 3 hrs to fix

    Function _doConnect has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    RabbitMQTransport.prototype._doConnect = function(callback) {
      //Transport.connect() guarantees that it doesn't call _doConnect if there is already
      //a valid connection
      assert(!this._connection);
      /** @constant
    Severity: Minor
    Found in lib/transportproviders/rabbitmqtransport.js - About 1 hr to fix

      Function start has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      ConsumeChannel.prototype.start = function(cb) {
        const self = this;
      
        this._consumeQueue.consume({}, function(msg, next) {
          const msgName = /*msg.options.type + ":" +*/ msg.name;
      Severity: Minor
      Found in lib/consume_channel.js - About 1 hr to fix

        Function rabbitMQConnectCallback has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          amqp.connect(amqpURI, { noDelay: amqpNoDelay }, function rabbitMQConnectCallback(err, conn) {
        // jscs:enable jsDoc
            if (err) {
              callback(err);
            } else {
        Severity: Minor
        Found in lib/transportproviders/rabbitmqtransport.js - About 1 hr to fix

          Function _rabbitMQMessageToMessage has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function _rabbitMQMessageToMessage(rmqMessage) {
            const options = _copyProperties(rmqMessage.properties, [
              "expiration",
              "correlationId",
              "replyTo",
          Severity: Minor
          Found in lib/transportproviders/rabbitmqtransport.js - About 1 hr to fix

            Function _doPublish has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            RabbitMQTransport.prototype._doPublish = function(exchangeName, msg, routingKey, callback) {
              const self = this;
              let rmqOptions = _messageOptionsToRabbitMQMessageOptions(msg);
            
              rmqOptions.headers.sequenceNumber = self._messageSequenceNumber++;
            Severity: Minor
            Found in lib/transportproviders/rabbitmqtransport.js - About 1 hr to fix

              Function Client has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function Client(clientName, transport, callback) {
                assert.ok(util.isString(clientName), "clientName must be a valid string");
                assert.ok(transport instanceof Transport);
              
                this._transport = transport;
              Severity: Minor
              Found in lib/client.js - About 1 hr to fix

                Function connect has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                Transport.prototype.connect = function(callback) {
                  const self = this;
                
                  if (this._isConnecting) {
                    this.once("connected", function () {
                Severity: Minor
                Found in lib/transport.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function disconnect has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                Transport.prototype.disconnect = function(callback) {
                  const self = this;
                
                  if (this._isDisconnecting) {
                    if (util.isFunction(callback)) {
                Severity: Minor
                Found in lib/transport.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _rabbitMQMessageToMessage has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                function _rabbitMQMessageToMessage(rmqMessage) {
                  const options = _copyProperties(rmqMessage.properties, [
                    "expiration",
                    "correlationId",
                    "replyTo",
                Severity: Minor
                Found in lib/transportproviders/rabbitmqtransport.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function connect has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                Transport.prototype.connect = function(callback) {
                  const self = this;
                
                  if (this._isConnecting) {
                    this.once("connected", function () {
                Severity: Minor
                Found in lib/transport.js - About 1 hr to fix

                  Function _doConnect has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                  RabbitMQTransport.prototype._doConnect = function(callback) {
                    //Transport.connect() guarantees that it doesn't call _doConnect if there is already
                    //a valid connection
                    assert(!this._connection);
                    /** @constant
                  Severity: Minor
                  Found in lib/transportproviders/rabbitmqtransport.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function _removeSIGINTHandler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function _removeSIGINTHandler(handler) {
                    /* istanbul ignore else */
                    if (handler) {
                      var listenerCount = 0;
                  
                  
                  Severity: Minor
                  Found in lib/transportproviders/rabbitmqtransport.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language