Sign upLogin

Kynetics/uf-android-client

View on GitHub
Star
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            /**
             * Class to build a message to configure the service.
             * When the new configuration can be applied live, a [UFServiceMessageV1.Event.ConfigurationUpdated] is notified.
             * When the new configuration requires a restart of the service, a [UFServiceMessageV1.Event.Stopped] and a
             * [UFServiceMessageV1.Event.Started] are notified.
Severity: Major
Found in uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt and 1 other location - About 2 hrs to fix
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 284..308

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            /**
             * Class to build a message to add target attributes
             *
             * @property targetAttributesWithPolicy, a Map of target attributes with an aggregation policy
             */
Severity: Major
Found in uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt and 1 other location - About 2 hrs to fix
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 167..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

            Communication.V1.Out.ServiceNotification.ID ->
                Communication.V1.Out.ServiceNotification(UFServiceMessageV1.fromJson(data.getString(
                    Communication.V1.SERVICE_DATA_KEY)!!))
Severity: Major
Found in uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt and 1 other location - About 1 hr to fix
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 44..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

            Communication.V1.Out.CurrentServiceConfigurationV2.ID -> Communication.V1.Out.CurrentServiceConfigurationV2(
                UFServiceConfigurationV2.fromJson(data.getString(Communication.V1.SERVICE_DATA_KEY)!!)
            )
Severity: Major
Found in uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt and 1 other location - About 1 hr to fix
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 31..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

                @Suppress("MemberVisibilityCanBePrivate") val conf: UFServiceConfiguration) : In(ID) {
                companion object {
                    const val ID = 1
                }
Severity: Minor
Found in uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt and 1 other location - About 55 mins to fix
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 241..254

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

            ) : In(ID) {
                companion object {
                    const val ID = 6
                }
Severity: Minor
Found in uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt and 1 other location - About 55 mins to fix
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 152..165

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Invalid

            /**
             * Class to build a message to unsubscribe a [Messenger] from the service notification
             * system.
             *
             * @property replyTo the [Messenger] to unsubscribe from the service notification system
Severity: Minor
Found in uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt and 2 other locations - About 35 mins to fix
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 196..211
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 256..276

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Invalid

            /**
             * Class to build a message to subscribe a [Messenger] to the service notification
             * system.
             *
             * @property replyTo the [Messenger] to subscribe to the service notification system
Severity: Minor
Found in uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt and 2 other locations - About 35 mins to fix
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 213..228
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 256..276

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Invalid

            /**
             * Class to build a sync message.
             * When the service receives a sync message it replies with two messages,
             * the first message contains the service state and the second message contains the
             * service configuration
Severity: Minor
Found in uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt and 2 other locations - About 35 mins to fix
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 196..211
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 213..228

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

            /**
             * This class represents a message that the [com.kynetics.uf.android.UpdateFactoryService]
             * sends to clients with the information about its state. This message is sent after each
             * polling request or as response of a [Communication.V1.In.Sync] message.
             *
Severity: Minor
Found in uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt and 1 other location - About 30 mins to fix
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 347..364

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

            /**
             * This class represents a message that the [com.kynetics.uf.android.UpdateFactoryService]
             * sends to clients when it is waiting for an user authorization
             *
             * @property authName is the kind of authorization, it is one between *DOWNLOAD* and *UPDATE*
Severity: Minor
Found in uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt and 1 other location - About 30 mins to fix
uf-client-service/uf-client-service-api/src/main/kotlin/com/kynetics/uf/android/api/Communication.kt on lines 326..345

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status