LLKennedy/httpgrpc

View on GitHub

Showing 125 of 125 total issues

Similar blocks of code found in 18 locations. Consider refactoring.
Open

        file_service_proto_msgTypes[3].Exporter = func(v interface{}, i int) interface{} {
            switch v := v.(*BroadcastData); i {
            case 0:
                return &v.state
            case 1:
Severity: Major
Found in internal/testservice/service/service.pb.go and 17 other locations - About 35 mins to fix
httpapi/proxy.pb.go on lines 642..653
httpapi/proxy.pb.go on lines 654..665
httpapi/proxy.pb.go on lines 666..677
httpapi/proxy.pb.go on lines 678..689
httpapi/proxy.pb.go on lines 690..701
httpapi/proxy.pb.go on lines 702..713
internal/testservice/service/service.pb.go on lines 857..868
internal/testservice/service/service.pb.go on lines 869..880
internal/testservice/service/service.pb.go on lines 881..892
internal/testservice/service/service.pb.go on lines 905..916
internal/testservice/service/service.pb.go on lines 917..928
internal/testservice/service/service.pb.go on lines 929..940
internal/testservice/service/service.pb.go on lines 941..952
internal/testservice/service/service.pb.go on lines 953..964
internal/testservice/service/service.pb.go on lines 965..976
internal/testservice/service/service.pb.go on lines 977..988
internal/testservice/service/service.pb.go on lines 989..1000

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

        file_service_proto_msgTypes[9].Exporter = func(v interface{}, i int) interface{} {
            switch v := v.(*RandomResponse); i {
            case 0:
                return &v.state
            case 1:
Severity: Major
Found in internal/testservice/service/service.pb.go and 17 other locations - About 35 mins to fix
httpapi/proxy.pb.go on lines 642..653
httpapi/proxy.pb.go on lines 654..665
httpapi/proxy.pb.go on lines 666..677
httpapi/proxy.pb.go on lines 678..689
httpapi/proxy.pb.go on lines 690..701
httpapi/proxy.pb.go on lines 702..713
internal/testservice/service/service.pb.go on lines 857..868
internal/testservice/service/service.pb.go on lines 869..880
internal/testservice/service/service.pb.go on lines 881..892
internal/testservice/service/service.pb.go on lines 893..904
internal/testservice/service/service.pb.go on lines 905..916
internal/testservice/service/service.pb.go on lines 917..928
internal/testservice/service/service.pb.go on lines 929..940
internal/testservice/service/service.pb.go on lines 941..952
internal/testservice/service/service.pb.go on lines 953..964
internal/testservice/service/service.pb.go on lines 977..988
internal/testservice/service/service.pb.go on lines 989..1000

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

        file_service_proto_msgTypes[10].Exporter = func(v interface{}, i int) interface{} {
            switch v := v.(*UploadPhotoRequest); i {
            case 0:
                return &v.state
            case 1:
Severity: Major
Found in internal/testservice/service/service.pb.go and 17 other locations - About 35 mins to fix
httpapi/proxy.pb.go on lines 642..653
httpapi/proxy.pb.go on lines 654..665
httpapi/proxy.pb.go on lines 666..677
httpapi/proxy.pb.go on lines 678..689
httpapi/proxy.pb.go on lines 690..701
httpapi/proxy.pb.go on lines 702..713
internal/testservice/service/service.pb.go on lines 857..868
internal/testservice/service/service.pb.go on lines 869..880
internal/testservice/service/service.pb.go on lines 881..892
internal/testservice/service/service.pb.go on lines 893..904
internal/testservice/service/service.pb.go on lines 905..916
internal/testservice/service/service.pb.go on lines 917..928
internal/testservice/service/service.pb.go on lines 929..940
internal/testservice/service/service.pb.go on lines 941..952
internal/testservice/service/service.pb.go on lines 953..964
internal/testservice/service/service.pb.go on lines 965..976
internal/testservice/service/service.pb.go on lines 989..1000

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getPattern has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func getPattern(args reflect.Type) (pattern apiMethodPattern) {
    defer func() {
        if r := recover(); r != nil {
            // Panic means something wasn't expected, which means this isn't a known pattern
            pattern = apiMethodPatternUnknown
Severity: Minor
Found in proxy/args.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getNativeTypeName has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
Open

func getNativeTypeName(field *descriptorpb.FieldDescriptorProto, message *descriptorpb.DescriptorProto, pkgName string, fileExports []string) string {
    repeatedStr := ""
    if field.GetLabel() == descriptorpb.FieldDescriptorProto_LABEL_REPEATED {
        repeatedStr = "[]"
    }
Severity: Minor
Found in internal/codegen/run.go - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language