Sign upLogin

LabPLC/verificalo

View on GitHub
Star
app/controllers/notices_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method modify has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def modify
    @errors = Hash.new
    @params = params

    begin
Severity: Minor
Found in app/controllers/notices_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method modify has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def modify
    @errors = Hash.new
    @params = params

    begin
Severity: Minor
Found in app/controllers/notices_controller.rb - About 1 hr to fix

    Method new_user has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def new_user
    begin
      raise unless type_param =~ /\A(EMAIL|PHONE)\z/
      @user = User.new(user_params)
    rescue
    Severity: Minor
    Found in app/controllers/notices_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method new_phone has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def new_phone
    begin
      @phone = @user.build_phone(phone_params)
    rescue
      @user.destroy
    Severity: Minor
    Found in app/controllers/notices_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method new has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def new
    @params = params
    @errors = Hash.new

    return unless new_user
    Severity: Minor
    Found in app/controllers/notices_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method new_phone has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def new_phone
    begin
      @phone = @user.build_phone(phone_params)
    rescue
      @user.destroy
    Severity: Minor
    Found in app/controllers/notices_controller.rb - About 1 hr to fix

      Method new_user_confirm has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def new_user_confirm
    if type_param == 'EMAIL'
      Notifier.confirm(@user).deliver
    elsif type_param == 'PHONE'
      @tw_req = { To: @user.phone.number.dup,
      Severity: Minor
      Found in app/controllers/notices_controller.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method new_email has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def new_email
    begin
      @email = @user.build_email(email_params)
    rescue
      @user.destroy
      Severity: Minor
      Found in app/controllers/notices_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status