Sign upLogin

LabPLC/verificalo

View on GitHub
Star
app/mailers/notifier.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

    return unless 
      # verificacion vencida
      ((user.no_circula_weekday || user.verificacion) && vehicle.verificacion_expired?) || 
      # nunca ha verificado
      ((user.no_circula_weekday || user.verificacion) && !vehicle.verificaciones_approved?) ||
Severity: Critical
Found in app/mailers/notifier.rb - About 3 hrs to fix

    Method weekday has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def weekday (user, vehicle) 
    return unless 
      # verificacion vencida
      ((user.no_circula_weekday || user.verificacion) && vehicle.verificacion_expired?) || 
      # nunca ha verificado
    Severity: Minor
    Found in app/mailers/notifier.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

        return unless 
      # nunca ha verificado
      (user.no_circula_weekend && !vehicle.verificaciones_approved?) ||
      # no circula holograma uno
      (user.no_circula_weekend && vehicle.no_circula_uno? && vehicle.no_circula_weekend?(saturday)) ||
    Severity: Major
    Found in app/mailers/notifier.rb - About 1 hr to fix

      Method weekend has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def weekend (user, vehicle, saturday)
    return unless 
      # nunca ha verificado
      (user.no_circula_weekend && !vehicle.verificaciones_approved?) ||
      # no circula holograma uno
      Severity: Minor
      Found in app/mailers/notifier.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status