Sign upLogin

LabPLC/verificalo

View on GitHub
Star

Showing 30 of 30 total issues

Method icon has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def icon (type)
    if type == :ok
      '<span class="glyphicon glyphicon-ok-sign green icon"></span>'.html_safe
    elsif type == :warning
      '<span class="glyphicon glyphicon-info-sign orange icon"></span>'.html_safe
Severity: Minor
Found in app/helpers/application_helper.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method new_user_confirm has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def new_user_confirm
    if type_param == 'EMAIL'
      Notifier.confirm(@user).deliver
    elsif type_param == 'PHONE'
      @tw_req = { To: @user.phone.number.dup,
Severity: Minor
Found in app/controllers/notices_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method verificaciones_all has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def verificaciones_all
    return false unless self.verificaciones?
    self.verificaciones.collect { |v|
      r = OpenStruct.new
      r.date = I18n.localize(Date.parse(v['fecha_verificacion']), :format => :default)
Severity: Minor
Found in lib/vehicle_cdmx.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method weekend has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def weekend (user, vehicle, saturday)
    return unless 
      # nunca ha verificado
      (user.no_circula_weekend && !vehicle.verificaciones_approved?) ||
      # no circula holograma uno
Severity: Minor
Found in app/mailers/notifier.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method verificaciones_vins has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def verificaciones_vins
    return false unless self.verificaciones?
    if self.user_vin_valid?
      return [ self.user_vin ]
    else
Severity: Minor
Found in lib/vehicle_cdmx.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def plate_last_digit_str
    return false if self.error
    plate_last_digit_str = {
      '1' => 'uno', '2' => 'dos', '3' => 'tres', '4' => 'cuatro', 
      '5' => 'cinco', '6' => 'seis', '7' => 'siete', '8' => 'ocho',
Severity: Minor
Found in lib/vehicle_cdmx.rb and 1 other location - About 35 mins to fix
lib/vehicle_cdmx.rb on lines 468..476

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def no_circula_weekday_str
    return false if self.error
    plate_no_circula_weekday = { 
      '1' => 'jueves', '2' => 'jueves',
      '3' => 'miércoles', '4' => 'miércoles',
Severity: Minor
Found in lib/vehicle_cdmx.rb and 1 other location - About 35 mins to fix
lib/vehicle_cdmx.rb on lines 103..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

      return false
Severity: Major
Found in lib/vehicle_cdmx.rb - About 30 mins to fix

    Method new_email has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def new_email
    begin
      @email = @user.build_email(email_params)
    rescue
      @user.destroy
    Severity: Minor
    Found in app/controllers/notices_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method reset has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def reset
    @params = params
    @session = session.to_hash
    redirect_to({ action: 'home' }) unless plate_param? || reset_param?
    if session.has_key?(:vin) && reset_vin?
    Severity: Minor
    Found in app/controllers/info_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language