# LiberTEM/LiberTEM

src/libertem/analysis/fullmatch.py

### Summary

B
5 hrs

#### Cyclomatic complexity is too high in method full_match. (9) Open

``````    def full_match(
self, centers, zero=None, cand=None,
refineds=None, peak_values=None, peak_elevations=None):
'''
This function extracts a list of Match objects as well two PointSelection objects``````
Found in src/libertem/analysis/fullmatch.py by radon

## Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

#### Function `_do_match` has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open

``````    def _do_match(self, point_selection: grm.PointSelection, zero, polar_vectors):
'''
Return a list with matches of all pairwise combinations of polar_vectors
'''
match_list = []``````
Found in src/libertem/analysis/fullmatch.py - About 2 hrs to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Cyclomatic complexity is too high in method _do_match. (7) Open

``````    def _do_match(self, point_selection: grm.PointSelection, zero, polar_vectors):
'''
Return a list with matches of all pairwise combinations of polar_vectors
'''
match_list = []``````
Found in src/libertem/analysis/fullmatch.py by radon

## Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

#### Function `full_match` has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open

``````    def full_match(
self, centers, zero=None, cand=None,
refineds=None, peak_values=None, peak_elevations=None):
'''
This function extracts a list of Match objects as well two PointSelection objects``````
Found in src/libertem/analysis/fullmatch.py - About 1 hr to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Function `__init__` has 12 arguments (exceeds 8 allowed). Consider refactoring. Open

``    def __init__(``
Found in src/libertem/analysis/fullmatch.py - About 1 hr to fix

#### Function `_hdbscan_candidates` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open

``````    def _hdbscan_candidates(self, points):
'''
Use hdbscan clustering to find potential candidates for lattice vectors.

We rely on the clusterer and its settings to give us tight and well-populated clusters.``````
Found in src/libertem/analysis/fullmatch.py - About 25 mins to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Method "__init__" has 13 parameters, which is greater than the 7 authorized. Open

``````            self, tolerance=3, min_weight=0.1, min_match=3, min_angle=np.pi/10,
min_points=10, min_delta=0, max_delta=np.inf, min_candidates=3,
max_candidates=7, clusterer=None, min_cluster_size_fraction=4,
min_samples_fraction=20):``````

A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

## Noncompliant Code Example

With a maximum number of 4 parameters:

```def do_something(param1, param2, param3, param4, param5):
...
```

## Compliant Solution

```def do_something(param1, param2, param3, param4):
...
```

#### Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. Open

``    def _do_match(self, point_selection: grm.PointSelection, zero, polar_vectors):``
Found in src/libertem/analysis/fullmatch.py by sonar-python

Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.