LiberTEM/LiberTEM

View on GitHub
src/libertem/executor/pipelined.py

Summary

Maintainability
D
2 days
Test Coverage

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

        assert all([e is not None for e in exitcodes])
Severity: Info
Found in src/libertem/executor/pipelined.py by bandit

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

                        assert len(id_to_task) == in_flight[0]
Severity: Info
Found in src/libertem/executor/pipelined.py by bandit

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

                assert len(id_to_task) == in_flight[0]

                # NOTE: this implements simple round-robin "scheduling";
                # as noted by @matbryan52 selecting the worker with the
                # currently shortest request queue could be a simple extension
Severity: Info
Found in src/libertem/executor/pipelined.py by bandit

File pipelined.py has 838 lines of code (exceeds 400 allowed). Consider refactoring.
Open

import itertools
import os
import gc
import sys
import signal
Severity: Major
Found in src/libertem/executor/pipelined.py - About 1 day to fix

    Cyclomatic complexity is too high in function worker_loop. (24)
    Open

    def worker_loop(
        queues: WorkerQueues,
        work_mem: Dict,
        worker_idx: int,
        env: Environment
    Severity: Minor
    Found in src/libertem/executor/pipelined.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function worker_loop has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

    def worker_loop(
        queues: WorkerQueues,
        work_mem: Dict,
        worker_idx: int,
        env: Environment
    Severity: Minor
    Found in src/libertem/executor/pipelined.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity is too high in method _start_pool. (11)
    Open

        def _start_pool(self) -> WorkerPool:
            with tracer.start_as_current_span("PipelinedExecutor.start_pool") as span:
                pool = WorkerPool(
                    worker_fn=functools.partial(
                        pipelined_worker,
    Severity: Minor
    Found in src/libertem/executor/pipelined.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in method close. (8)
    Open

        def close(self):
            with tracer.start_as_current_span("PipelinedExecutor.close") as span:
                if self._closed:
                    return
                for idx, worker_info in enumerate(self._pool.workers):
    Severity: Minor
    Found in src/libertem/executor/pipelined.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in function _order_results. (7)
    Open

    def _order_results(results_in: ResultWithID) -> ResultT:
        """
        Order the `results_in` generator by the result id, yielding ordered results.
        Requires indexes to be without gaps.
        """
    Severity: Minor
    Found in src/libertem/executor/pipelined.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in method _run_tasks_inner. (6)
    Open

        def _run_tasks_inner(
            self,
            tasks: Iterable[TaskProtocol],
            params_handle: Any,
            cancel_id: Any,
    Severity: Minor
    Found in src/libertem/executor/pipelined.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function _start_pool has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def _start_pool(self) -> WorkerPool:
            with tracer.start_as_current_span("PipelinedExecutor.start_pool") as span:
                pool = WorkerPool(
                    worker_fn=functools.partial(
                        pipelined_worker,
    Severity: Minor
    Found in src/libertem/executor/pipelined.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _order_results has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def _order_results(results_in: ResultWithID) -> ResultT:
        """
        Order the `results_in` generator by the result id, yielding ordered results.
        Requires indexes to be without gaps.
        """
    Severity: Minor
    Found in src/libertem/executor/pipelined.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            with tracer.start_as_current_span("SHUTDOWN") as span:
                                queues.request.close()
                                queues.response.close(drain=False)
                                queues.message.close(drain=False)
                            break
    Severity: Major
    Found in src/libertem/executor/pipelined.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              with tracer.start_as_current_span("WARMUP"):
                                  import libertem.udf.base  # NOQA
                                  import libertem.api  # NOQA
                                  import libertem.preload  # NOQA
                                  with env.enter():
      Severity: Major
      Found in src/libertem/executor/pipelined.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                with tracer.start_as_current_span("drain after task") as span:
                                    while True:
                                        with queues.request.get() as msg:
                                            header, payload = msg
                                            header_type = header["type"]
        Severity: Major
        Found in src/libertem/executor/pipelined.py - About 45 mins to fix

          Function kill_worker has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def kill_worker(self, worker_info: PoolWorkerInfo, timeout: float = 5.0):
                  worker_info.queues.request.close(drain=False, force=True)
                  worker_info.process.terminate()
                  worker_info.process.join(timeout)
                  if worker_info.process.exitcode is None:
          Severity: Minor
          Found in src/libertem/executor/pipelined.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status