LiberTEM/LiberTEM

View on GitHub
src/libertem/io/dataset/hdf5.py

Summary

Maintainability
C
1 day
Test Coverage

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

        assert all(ts <= ps for (ts, ps) in zip(tileshape_nd, self.slice_nd.shape))

Severity: Info
Found in src/libertem/io/dataset/hdf5.py by bandit

Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.
Open

        assert len(tiling_scheme) == 1, "incompatible tiling scheme! (%r)" % (tiling_scheme)

Severity: Info
Found in src/libertem/io/dataset/hdf5.py by bandit

File hdf5.py has 602 lines of code (exceeds 400 allowed). Consider refactoring.
Open

import contextlib
from typing import Optional
import warnings
import logging
import time
Severity: Major
Found in src/libertem/io/dataset/hdf5.py - About 6 hrs to fix

    H5DataSet has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class H5DataSet(DataSet):
        """
        Read data from a HDF5 data set.
    
        Examples
    Severity: Minor
    Found in src/libertem/io/dataset/hdf5.py - About 2 hrs to fix

      Cyclomatic complexity is too high in method _get_subslices. (7)
      Open

          def _get_subslices(self, tiling_scheme):
              """
              Generate partition subslices for the given tiling scheme for the different cases.
              """
              if tiling_scheme.intent == "partition":
      Severity: Minor
      Found in src/libertem/io/dataset/hdf5.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in method get_partitions. (6)
      Open

          def get_partitions(self):
              ds_shape = Shape(self.shape, sig_dims=self.sig_dims)
              ds_slice = Slice(origin=[0] * len(self.shape), shape=ds_shape)
              target_size = self.target_size
              if target_size is None:
      Severity: Minor
      Found in src/libertem/io/dataset/hdf5.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Cyclomatic complexity is too high in method adjust_tileshape. (6)
      Open

          def adjust_tileshape(self, tileshape, roi):
              chunks = self._chunks
              sig_shape = self.shape.sig
              if roi is not None:
                  return (1,) + sig_shape
      Severity: Minor
      Found in src/libertem/io/dataset/hdf5.py by radon

      Cyclomatic Complexity

      Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

      Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

      Construct Effect on CC Reasoning
      if +1 An if statement is a single decision.
      elif +1 The elif statement adds another decision.
      else +0 The else statement does not cause a new decision. The decision is at the if.
      for +1 There is a decision at the start of the loop.
      while +1 There is a decision at the while statement.
      except +1 Each except branch adds a new conditional path of execution.
      finally +0 The finally block is unconditionally executed.
      with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
      assert +1 The assert statement internally roughly equals a conditional statement.
      Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
      Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

      Source: http://radon.readthedocs.org/en/latest/intro.html

      Function _get_subslices has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def _get_subslices(self, tiling_scheme):
              """
              Generate partition subslices for the given tiling scheme for the different cases.
              """
              if tiling_scheme.intent == "partition":
      Severity: Minor
      Found in src/libertem/io/dataset/hdf5.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_partitions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_partitions(self):
              ds_shape = Shape(self.shape, sig_dims=self.sig_dims)
              ds_slice = Slice(origin=[0] * len(self.shape), shape=ds_shape)
              target_size = self.target_size
              if target_size is None:
      Severity: Minor
      Found in src/libertem/io/dataset/hdf5.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _get_subslices_chunked_tiled has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def _get_subslices_chunked_tiled(self, tiling_scheme, scheme_lookup, nav_dims, tileshape_nd):
              """
              general tiled reading w/ chunking outer loop is a chunk in
              signal dimensions, inner loop is over "rows in nav"
              """
      Severity: Minor
      Found in src/libertem/io/dataset/hdf5.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status