MPOS/php-mpos

View on GitHub

Showing 1,089 of 1,089 total issues

Method doImages has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function doImages($text) {
    #
    # Turn Markdown image shortcuts into <img> tags.
    #
        #
Severity: Minor
Found in include/lib/Michelf/Markdown.php - About 1 hr to fix

    Method loadConfigVars has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function loadConfigVars($sections = null, $scope = 'local')
        {
            if ($this->data instanceof Smarty_Internal_Template) {
                $this->data->properties['file_dependency'][sha1($this->source->filepath)] = array($this->source->filepath, $this->source->timestamp, 'file');
            }
    Severity: Minor
    Found in include/smarty/libs/sysplugins/smarty_internal_config.php - About 1 hr to fix

      Method getAllWorkers has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public function getAllWorkers($iLimit=0, $interval=600, $start=0) {
          $this->debug->append("STA " . __METHOD__, 4);
          $stmt = $this->mysqli->prepare("
            SELECT id, username, password, monitor,
              (
      Severity: Minor
      Found in include/classes/worker.class.php - About 1 hr to fix

        Method updatePassword has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public function updatePassword($userID, $current, $new1, $new2, $strToken) {
            $this->debug->append("STA " . __METHOD__, 4);
            if ($new1 !== $new2) {
              $this->setErrorMessage( 'New passwords do not match' );
              return false;
        Severity: Minor
        Found in include/classes/user.class.php - About 1 hr to fix

          Method log has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            public function log($strType, $strMessage) {
              // Logmask, we add some infos into the KLogger
              $strMask = "[ %12s ] [ %8s | %-8s ] [ %7.7s ] : %s";
              $strIPAddress = isset($_SERVER['REMOTE_ADDR']) ? $_SERVER['REMOTE_ADDR'] : 'unknown';
              $strPage = isset($_REQUEST['page']) ? $_REQUEST['page'] : 'none';
          Severity: Minor
          Found in include/classes/logger.class.php - About 1 hr to fix

            Method send has 42 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function send(Swift_Mime_Message $message, &$failedRecipients = null)
                {
                    $failedRecipients = (array) $failedRecipients;
                    $command = $this->getCommand();
                    $buffer = $this->getBuffer();

              Method doImages has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function doImages($text) {
                  #
                  # Turn Markdown image shortcuts into <img> tags.
                  #
                      #
              Severity: Minor
              Found in include/lib/Michelf/Markdown.php - About 1 hr to fix

                Method smarty_function_counter has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function smarty_function_counter($params, $template)
                {
                    static $counters = array();
                
                    $name = (isset($params['name'])) ? $params['name'] : 'default';
                Severity: Minor
                Found in include/smarty/libs/plugins/function.counter.php - About 1 hr to fix

                  Method getPlugin has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getPlugin($plugin_name, $plugin_type)
                      {
                          $function = null;
                          if ($this->template->caching && ($this->nocache || $this->tag_nocache)) {
                              if (isset($this->template->required_plugins['nocache'][$plugin_name][$plugin_type])) {

                    Method getWorkers has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      public function getWorkers($account_id, $interval=600) {
                        $this->debug->append("STA " . __METHOD__, 4);
                        $stmt = $this->mysqli->prepare("
                          SELECT id, username, password, monitor,
                            (
                    Severity: Minor
                    Found in include/classes/worker.class.php - About 1 hr to fix

                      Method fetchAllUserMiningStats has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        public function fetchAllUserMiningStats($interval=180) {
                          $this->debug->append("STA " . __METHOD__, 4);
                          $stmt = $this->mysqli->prepare("
                            SELECT
                              a.id AS id,
                      Severity: Minor
                      Found in include/classes/statistics.class.php - About 1 hr to fix

                        Method smarty_mb_wordwrap has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            function smarty_mb_wordwrap($str, $width=75, $break="\n", $cut=false)
                            {
                                // break words into tokens using white space as a delimiter
                                $tokens = preg_split('!(\s)!S' . Smarty::$_UTF8_MODIFIER, $str, -1, PREG_SPLIT_NO_EMPTY + PREG_SPLIT_DELIM_CAPTURE);
                                $length = 0;
                        Severity: Minor
                        Found in include/smarty/libs/plugins/shared.mb_wordwrap.php - About 1 hr to fix

                          Method getUserMiningStats has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            public function getUserMiningStats($username, $account_id=NULL, $interval=180) {
                              $this->debug->append("STA " . __METHOD__, 4);
                              // Dual-caching, try statistics cron first, then fallback to local, then fallbock to SQL
                              if ($this->getGetCache() && $data = $this->memcache->getStatic(STATISTICS_ALL_USER_HASHRATES)) {
                                if (array_key_exists($account_id, $data['data'])) {
                          Severity: Minor
                          Found in include/classes/statistics.class.php - About 1 hr to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                            function getPassStrength(score) {
                              if (score === 4)
                                return "Excellent";
                              if (score === 3)
                                return "Strong";
                            Severity: Major
                            Found in public/site_assets/bootstrap/js/pwcheck.js and 1 other location - About 1 hr to fix
                            public/site_assets/bootstrap/js/pwcheck.js on lines 20..32

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 67.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                            function getStrengthColor(score) {
                              if (score === 4)
                                return "#390";
                              if (score === 3)
                                return "#3C0";
                            Severity: Major
                            Found in public/site_assets/bootstrap/js/pwcheck.js and 1 other location - About 1 hr to fix
                            public/site_assets/bootstrap/js/pwcheck.js on lines 6..18

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 67.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Method addSignature has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function addSignature(Swift_Mime_HeaderSet $headers)
                                {
                                    // Prepare the DKIM-Signature
                                    $params = array('v' => '1', 'a' => $this->_hashAlgorithm, 'bh' => base64_encode($this->_bodyHash), 'd' => $this->_domainName, 'h' => implode(': ', $this->_signedHeaders), 'i' => $this->_signerIdentity, 's' => $this->_selector);
                                    if ($this->_bodyCanon != 'simple') {
                            Severity: Minor
                            Found in include/lib/swiftmailer/classes/Swift/Signers/DKIMSigner.php - About 1 hr to fix

                              Function trigger_template_error has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public function trigger_template_error($args = null, $line = null)
                                  {
                                      // get template source line which has error
                                      if (!isset($line)) {
                                          $line = $this->lex->line;

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function registerObject has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public function registerObject($object_name, $object_impl, $allowed = array(), $smarty_args = true, $block_methods = array())
                                  {
                                      // test if allowed methodes callable
                                      if (!empty($allowed)) {
                                          foreach ((array) $allowed as $method) {
                              Severity: Minor
                              Found in include/smarty/libs/sysplugins/smarty_internal_templatebase.php - About 1 hr to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function compile has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public function compile($args, $compiler, $parameter)
                                  {
                                      // check and get attributes
                                      $_attr = $this->getAttributes($compiler, $args);
                                      $this->openTag($compiler, 'if', array(1, $compiler->nocache));
                              Severity: Minor
                              Found in include/smarty/libs/sysplugins/smarty_internal_compile_if.php - About 1 hr to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function compile has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public function compile($args, $compiler, $parameter)
                                  {
                                      // check and get attributes
                                      $_attr = $this->getAttributes($compiler, $args);
                                      $this->openTag($compiler, 'while', $compiler->nocache);
                              Severity: Minor
                              Found in include/smarty/libs/sysplugins/smarty_internal_compile_while.php - About 1 hr to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language