MPOS/php-mpos

View on GitHub

Showing 1,089 of 1,089 total issues

Function setParam has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function setParam($param, $value)
    {
        if (isset($this->_stream)) {
            switch ($param) {
                case 'timeout':
Severity: Minor
Found in include/lib/swiftmailer/classes/Swift/Transport/StreamBuffer.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function read has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function read($length)
    {
        if (isset($this->_out) && !feof($this->_out)) {
            $ret = fread($this->_out, $length);
            if (strlen($ret)==0) {
Severity: Minor
Found in include/lib/swiftmailer/classes/Swift/Transport/StreamBuffer.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _doImages_reference_callback has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function _doImages_reference_callback($matches) {
        $whole_match = $matches[1];
        $alt_text    = $matches[2];
        $link_id     = strtolower($matches[3]);

Severity: Minor
Found in include/lib/Michelf/Markdown.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

        /* 57 */ array(1, 30, 36, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, ),
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 825..825
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 826..826
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 828..828
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 829..829

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

        /* 58 */ array(1, 30, 36, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, ),
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 825..825
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 826..826
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 827..827
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 829..829

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

        /* 59 */ array(1, 30, 36, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, ),
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 825..825
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 826..826
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 827..827
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 828..828

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

        /* 55 */ array(1, 30, 36, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, ),
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 826..826
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 827..827
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 828..828
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 829..829

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 5 locations. Consider refactoring.
Open

        /* 56 */ array(1, 30, 36, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, ),
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 825..825
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 827..827
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 828..828
include/smarty/libs/sysplugins/smarty_internal_templateparser.php on lines 829..829

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

            return $return;
Severity: Major
Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return;
    Severity: Major
    Found in include/smarty/libs/plugins/function.fetch.php - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return "Extremely weak";
      Severity: Major
      Found in public/site_assets/bootstrap/js/pwcheck.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          return "#999";
        Severity: Major
        Found in public/site_assets/bootstrap/js/pwcheck.js - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $return;
          Severity: Major
          Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                return "1 month ago"; 
            Severity: Major
            Found in include/smarty/libs/plugins/modifier.relative_date.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return 'htmlentities('
                                      . $params[0] .', ENT_QUOTES, '
                                      . var_export($char_set, true) . ')';
              Severity: Major
              Found in include/smarty/libs/plugins/modifiercompiler.escape.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                    return htmlentities($string, ENT_QUOTES, $char_set);
                Severity: Major
                Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return $return;
                  Severity: Major
                  Found in include/smarty/libs/plugins/modifier.escape.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                        return intval($difference / (60*60*24*7)) . " weeks ago"; 
                    Severity: Major
                    Found in include/smarty/libs/plugins/modifier.relative_date.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                        return @date($format, $timestamp);
                      Severity: Major
                      Found in include/smarty/libs/plugins/modifier.relative_date.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return substr($string, 0, $length / 2) . $etc . substr($string, - $length / 2);
                        Severity: Major
                        Found in include/smarty/libs/plugins/modifier.truncate.php - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language