Sign upLogin

MPOS/php-mpos

View on GitHub
Star

Showing 1,089 of 1,089 total issues

Method getUserEstimates has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  public function getUserEstimates($value1, $value2, $dDonate, $bNoFees, $ppsvalue=0) {
Severity: Minor
Found in include/classes/statistics.class.php - About 35 mins to fix

    Method endCronjob has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      public function endCronjob($cron_name, $msgCode, $exitCode=0, $fatal=false, $mail=true) {
    Severity: Minor
    Found in include/classes/monitoring.class.php - About 35 mins to fix

      Method createLMv2Password has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function createLMv2Password($password, $username, $domain, $challenge, $client)
      Severity: Minor
      Found in include/lib/swiftmailer/classes/Swift/Transport/Esmtp/Auth/NTLMAuthenticator.php - About 35 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct(Swift_Mime_HeaderSet $headers, Swift_Mime_ContentEncoder $encoder, Swift_KeyCache $cache, Swift_Mime_Grammar $grammar, $mimeTypes = array())
        Severity: Minor
        Found in include/lib/swiftmailer/classes/Swift/Mime/EmbeddedFile.php - About 35 mins to fix

          Method onCommand has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function onCommand(Swift_Transport_SmtpAgent $agent, $command, $codes = array(), &$failedRecipients = null, &$stop = false)
          Severity: Minor
          Found in include/lib/swiftmailer/classes/Swift/Transport/Esmtp/AuthHandler.php - About 35 mins to fix

            Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function __construct(Swift_Mime_HeaderSet $headers, Swift_Mime_ContentEncoder $encoder, Swift_KeyCache $cache, Swift_Mime_Grammar $grammar, $charset = null)
            Severity: Minor
            Found in include/lib/swiftmailer/classes/Swift/Mime/SimpleMessage.php - About 35 mins to fix

              Method onCommand has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function onCommand(Swift_Transport_SmtpAgent $agent, $command, $codes = array(), &$failedRecipients = null, &$stop = false);
              Severity: Minor
              Found in include/lib/swiftmailer/classes/Swift/Transport/EsmtpHandler.php - About 35 mins to fix

                Method createMessage3 has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    protected function createMessage3($domain, $username, $workstation, $lmResponse, $ntlmResponse)
                Severity: Minor
                Found in include/lib/swiftmailer/classes/Swift/Transport/Esmtp/Auth/NTLMAuthenticator.php - About 35 mins to fix

                  Method mail has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function mail($to, $subject, $body, $headers = null, $extraParams = null)
                  Severity: Minor
                  Found in include/lib/swiftmailer/classes/Swift/Transport/SimpleMailInvoker.php - About 35 mins to fix

                    Method mail has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function mail($to, $subject, $body, $headers = null, $extraParams = null);
                    Severity: Minor
                    Found in include/lib/swiftmailer/classes/Swift/Transport/MailInvoker.php - About 35 mins to fix

                      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function __construct(Swift_Mime_HeaderSet $headers, Swift_Mime_ContentEncoder $encoder, Swift_KeyCache $cache, Swift_Mime_Grammar $grammar, $mimeTypes = array())
                      Severity: Minor
                      Found in include/lib/swiftmailer/classes/Swift/Mime/Attachment.php - About 35 mins to fix

                        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function __construct(Swift_Mime_HeaderSet $headers, Swift_Mime_ContentEncoder $encoder, Swift_KeyCache $cache, Swift_Mime_Grammar $grammar, $charset = null)
                        Severity: Minor
                        Found in include/lib/swiftmailer/classes/Swift/Mime/MimePart.php - About 35 mins to fix

                          Method createPhrase has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              protected function createPhrase(Swift_Mime_Header $header, $string, $charset, Swift_Mime_HeaderEncoder $encoder = null, $shorten = false)
                          Severity: Minor
                          Found in include/lib/swiftmailer/classes/Swift/Mime/Headers/AbstractHeader.php - About 35 mins to fix

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                            <?php
function run_007() {
  // Ugly but haven't found a better way
  global $setting;
                            Severity: Minor
                            Found in upgrade/definitions/0.0.6_to_0.0.7.inc.php and 2 other locations - About 35 mins to fix
                            upgrade/definitions/0.0.1_to_0.0.2.inc.php on lines 1..19
                            upgrade/definitions/0.0.5_to_0.0.6.inc.php on lines 1..19

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 92.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                            <?php
function run_002() {
  // Ugly but haven't found a better way
  global $setting;
                            Severity: Minor
                            Found in upgrade/definitions/0.0.1_to_0.0.2.inc.php and 2 other locations - About 35 mins to fix
                            upgrade/definitions/0.0.5_to_0.0.6.inc.php on lines 1..19
                            upgrade/definitions/0.0.6_to_0.0.7.inc.php on lines 1..19

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 92.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                            <?php
function run_006() {
  // Ugly but haven't found a better way
  global $setting;
                            Severity: Minor
                            Found in upgrade/definitions/0.0.5_to_0.0.6.inc.php and 2 other locations - About 35 mins to fix
                            upgrade/definitions/0.0.1_to_0.0.2.inc.php on lines 1..19
                            upgrade/definitions/0.0.6_to_0.0.7.inc.php on lines 1..19

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 92.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Function enableSecurity has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function enableSecurity($security_class = null)
    {
        if ($security_class instanceof Smarty_Security) {
            $this->security_policy = $security_class;
                            Severity: Minor
                            Found in include/smarty/libs/Smarty.class.php - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function getGlobal has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function getGlobal($varname = null)
    {
        if (isset($varname)) {
            if (isset(self::$global_tpl_vars[$varname])) {
                return self::$global_tpl_vars[$varname]->value;
                            Severity: Minor
                            Found in include/smarty/libs/Smarty.class.php - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function isTrustedUri has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function isTrustedUri($uri)
    {
        $_uri = parse_url($uri);
        if (!empty($_uri['scheme']) && !empty($_uri['host'])) {
            $_uri = $_uri['scheme'] . '://' . $_uri['host'];
                            Severity: Minor
                            Found in include/smarty/libs/sysplugins/smarty_security.php - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function parse_single_quoted_string has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                                private static function parse_single_quoted_string($qstr) {
        $escaped_string = substr($qstr, 1, strlen($qstr)-2); //remove outer quotes

        $ss = preg_split('/(\\\\.)/', $escaped_string, -1, PREG_SPLIT_DELIM_CAPTURE);
                            Severity: Minor
                            Found in include/smarty/libs/sysplugins/smarty_internal_configfileparser.php - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language