MailOnline/flashVPAID

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it('must implement setWidth', function () {
        var instance = new JSFlashBridge(el, 'url', EL_ID, 15, 10, noop);
        assert.isFunction(instance.setWidth);

        assert.deepEqual(instance.getWidth(), 15);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it('must implement setHeight', function () {
        var instance = new JSFlashBridge(el, 'url', EL_ID, 15, 10, noop);
        assert.isFunction(instance.setHeight);

        assert.deepEqual(instance.getHeight(), 10);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it('implements removeByValue', function () {
        var data = {hello: 'hello'};
        var key = 'hello';

        registry.add(key, data);

• Read up
  Read up

VPAIDAdUnit has 26 functions (exceeds 20 allowed). Consider refactoring.

Open

export class VPAIDAdUnit extends IVPAIDAdUnit {
    constructor (flash) {
        super();
        this._destroyed = false;
        this._flash = flash;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it('implements remove', function () {
        var data = {hello: 'hello'};
        var key = 'hello';

        registry.add(key, data);

• Read up
  Read up

JSFlashBridge has 22 functions (exceeds 20 allowed). Consider refactoring.

Open

export class JSFlashBridge {
    constructor (el, flashURL, flashID, width, height, loadHandShake) {
        this._el = el;
        this._flashID = flashID;
        this._flashURL = flashURL;

IVPAIDAdUnit has 21 functions (exceeds 20 allowed). Consider refactoring.

Open

export class IVPAIDAdUnit {

    //all methods below
    //are async methods
    handshakeVersion(playerVPAIDVersion = '2.0', callback = undefined) {}

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    [
        'startAd',
        'stopAd',
        'pauseAd',
        'resumeAd',

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    [
        'getAdLinear',
        'getAdWidth',
        'getAdHeight',
        'getAdExpanded',

• Read up
  Read up

Function flashVPAIDWrapperLoaded has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function flashVPAIDWrapperLoaded(err) {
    if (err) return;
    // var adURL = 'http://cdn.innovid.com/2.62.8110/platform/vpaid/VPAIDIRollPackage.swf?configURL=http%3A%2F%2Fstatic.innovid.com%2Firoll%2Fconfig%2F1hl7lc.xml%3Fcb%3D787766d7-ebab-3656-c24f-0ddebab645e9&secure=false';
    // var adURL = 'VPAIDIRollPackage.swf?configURL=http%3A%2F%2Fstatic.innovid.com%2Firoll%2Fconfig%2F1hl7lc.xml%3Fcb%3D787766d7-ebab-3656-c24f-0ddebab645e9&secure=false';
    // var adURL = 'TestAd.swf';

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        it('must be implemented', function () {
            assert(utils.stringEndsWith('test_cool', 'cool'));
            assert(!utils.stringEndsWith('test_coolx_test', 'coolx'));
            assert(utils.stringEndsWith('test_coolx', 'coolx'));
        });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            it('must still work', function () {
                assert(utils.stringEndsWith('test_cool', 'cool'));
                assert(!utils.stringEndsWith('test_coolx_test', 'coolx'));
                assert(utils.stringEndsWith('test_coolx', 'coolx'));
            });

• Read up
  Read up

Function exports has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

module.exports = function (karma) {
  karma.set({
    /**
     * From where to look for files, starting with the location of this file.
     */

Function constructor has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    constructor (vpaidParentEl, callback, swfConfig = {data: 'VPAIDFlash.swf', width: 800, height: 400}, params = { wmode: 'transparent', salign: 'tl', align: 'left', allowScriptAccess: 'always', scale: 'noScale', allowFullScreen: 'true', quality: 'high'}, vpaidOptions = { debug: false, timeout: 10000 }) {

        var me = this;

        this._vpaidParentEl = vpaidParentEl;

Function flashVPAID has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        let flashVPAID = new VPAIDFLASHClient(flashWrapper1, function () {

            flashVPAID.loadAdUnit('random.swf', function (error, adUnit) {

                let callback1 = sinon.spy();

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe('isSupported', function() {
        it('must be a function', function() {
            const flashTester = createFlashTester(flashWrapper);
            assert.isFunction(flashTester.isSupported);
        });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe('on', function() {
        it('must be a function', function() {
            const flashTester = createFlashTester(flashWrapper);
            assert.isFunction(flashTester.on);
        });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

Object.defineProperty(JSFlashBridgeRegistry, 'getInstanceByID', {
    writable: false,
    configurable: false,
    value: function (id) {
        return instances.get(id);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

Object.defineProperty(JSFlashBridgeRegistry, 'removeInstanceByID', {
    writable: false,
    configurable: false,
    value: function (id) {
        return instances.remove(id);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

let ALL_VPAID_METHODS = Object.getOwnPropertyNames(IVPAIDAdUnit.prototype).filter(function (property) {
    return ['constructor'].indexOf(property) === -1;
});

• Read up
  Read up