ManageIQ/manageiq-api

View on GitHub
app/controllers/api/base_controller/logger.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
94%

Use caller(1..1).first instead of caller.first.
Open

        method = api_get_method_name(caller.first, __method__)

This cop identifies places where caller[n] can be replaced by caller(n..n).first.

Example:

# bad
caller[1]
caller.first
caller_locations[1]
caller_locations.first

# good
caller(2..2).first
caller(1..1).first
caller_locations(2..2).first
caller_locations(1..1).first

Use caller(1..1).first instead of caller.first.
Open

        method = api_get_method_name(caller.first, __method__)

This cop identifies places where caller[n] can be replaced by caller(n..n).first.

Example:

# bad
caller[1]
caller.first
caller_locations[1]
caller_locations.first

# good
caller(2..2).first
caller(1..1).first
caller_locations(2..2).first
caller_locations(1..1).first

Use caller(1..1).first instead of caller.first.
Open

        method = api_get_method_name(caller.first, __method__)

This cop identifies places where caller[n] can be replaced by caller(n..n).first.

Example:

# bad
caller[1]
caller.first
caller_locations[1]
caller_locations.first

# good
caller(2..2).first
caller(1..1).first
caller_locations(2..2).first
caller_locations(1..1).first

Use caller(1..1).first instead of caller.first.
Open

          method = api_get_method_name(caller.first, __method__)

This cop identifies places where caller[n] can be replaced by caller(n..n).first.

Example:

# bad
caller[1]
caller.first
caller_locations[1]
caller_locations.first

# good
caller(2..2).first
caller(1..1).first
caller_locations(2..2).first
caller_locations(1..1).first

There are no issues that match your filters.

Category
Status