Sign upLogin

ManageIQ/manageiq-api

View on GitHub
Star
app/controllers/api/subcollections/policies.rb

Summary

Maintainability
A
50 mins
Test Coverage
C
78%

Use match? instead of =~ when MatchData is not used.
Open

        if href =~ %r{^.*/#{collection}/\d+$}
Severity: Minor
Found in app/controllers/api/subcollections/policies.rb by rubocop

In Ruby 2.4, String#match?, Regexp#match? and Symbol#match? have been added. The methods are faster than match. Because the methods avoid creating a MatchData object or saving backref. So, when MatchData is not used, use match? instead of match.

Example:

# bad
def foo
  if x =~ /re/
    do_something
  end
end

# bad
def foo
  if x.match(/re/)
    do_something
  end
end

# bad
def foo
  if /re/ === x
    do_something
  end
end

# good
def foo
  if x.match?(/re/)
    do_something
  end
end

# good
def foo
  if x =~ /re/
    do_something(Regexp.last_match)
  end
end

# good
def foo
  if x.match(/re/)
    do_something($~)
  end
end

# good
def foo
  if /re/ === x
    do_something($~)
  end
end

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      def policy_unassign_action(object, ctype, id, data)
        klass  = collection_class(ctype)
        policy = policy_specified(id, data, ctype, klass)
        policy_subcollection_action(ctype, policy) do
          api_log_info("Unassigning #{policy_ident(ctype, policy)}")
Severity: Minor
Found in app/controllers/api/subcollections/policies.rb and 2 other locations - About 15 mins to fix
app/controllers/api/subcollections/policies.rb on lines 66..71
app/controllers/api/subcollections/policies.rb on lines 84..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      def policy_assign_action(object, ctype, id, data)
        klass  = collection_class(ctype)
        policy = policy_specified(id, data, ctype, klass)
        policy_subcollection_action(ctype, policy) do
          api_log_info("Assigning #{policy_ident(ctype, policy)}")
Severity: Minor
Found in app/controllers/api/subcollections/policies.rb and 2 other locations - About 15 mins to fix
app/controllers/api/subcollections/policies.rb on lines 75..80
app/controllers/api/subcollections/policies.rb on lines 84..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      def policy_resolve_action(object, ctype, id, data)
        klass  = collection_class(ctype)
        policy = policy_specified(id, data, ctype, klass)
        policy_subcollection_action(ctype, policy) do
          api_log_info("Resolving #{policy_ident(ctype, policy)}")
Severity: Minor
Found in app/controllers/api/subcollections/policies.rb and 2 other locations - About 15 mins to fix
app/controllers/api/subcollections/policies.rb on lines 66..71
app/controllers/api/subcollections/policies.rb on lines 75..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status