Sign upLogin

ManageIQ/manageiq-providers-ansible_tower

View on GitHub
Star
app/models/manageiq/providers/ansible_tower/inventory/collector/target_collection.rb

Summary

Maintainability
A
1 hr
Test Coverage
A
100%

Method infer_related_manager_refs! has a Cognitive Complexity of 17 (exceeds 11 allowed). Consider refactoring.
Open

  def infer_related_manager_refs!
    if references(:configured_systems).present?
      hosts.each do |host|
        add_simple_target!(:inventory_root_groups, host.inventory_id.to_s)
      end
Severity: Minor
Found in app/models/manageiq/providers/ansible_tower/inventory/collector/target_collection.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid immutable Array literals in loops. It is better to extract it into a local variable or a constant.
Open

        %w(credential_id cloud_credential_id network_credential_id).each do |credential_attr|
Severity: Minor
Found in app/models/manageiq/providers/ansible_tower/inventory/collector/target_collection.rb by rubocop

There are no issues that match your filters.

Category
Status