Sign upLogin

Maroc-OS/decompiler

View on GitHub
Star

Showing 2,968 of 2,968 total issues

Function is_parent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def is_parent(self, wanted):
    """ Check if 'obj' is a parent of 'self'. """
    import statements
    obj = self
    while obj:
Severity: Minor
Found in src/expressions.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def get_ea_name(self, ea):
    """ return the name of this location, or None if no name is defined. """
    if ea in self.names:
      return self.names[ea]
Severity: Minor
Found in src/host/capstone/dis/intel.py and 1 other location - About 35 mins to fix
src/host/capstone/dis/intel.py on lines 30..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def index(self):
    """ return the statement index inside its parent
        container, or None if container is None """
    if self.container is None:
        return
Severity: Minor
Found in src/statements.py and 1 other location - About 35 mins to fix
src/statements.py on lines 23..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def remove(self):
    """ removes the statement from its container. return True if
        container is not None and the removal succeeded. """
    if self.container is None:
        return
Severity: Minor
Found in src/statements.py and 1 other location - About 35 mins to fix
src/statements.py on lines 16..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def get_string(self, ea):
    """ return the string starting at 'ea' or None if it is not a string. """
    if ea in self.strings:
      return self.strings[ea]
Severity: Minor
Found in src/host/capstone/dis/intel.py and 1 other location - About 35 mins to fix
src/host/capstone/dis/intel.py on lines 25..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    return expr.op.op.pluck()
Severity: Major
Found in src/filters/simplify_expressions.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return b_not_t(expr.op1.pluck())
    Severity: Major
    Found in src/filters/simplify_expressions.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return aeq_t(expr.op.op1.pluck(), expr.op.op2.pluck())
      Severity: Major
      Found in src/filters/simplify_expressions.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return eq_t(expr.op.op1.pluck(), expr.op.op2.pluck())
        Severity: Major
        Found in src/filters/simplify_expressions.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return isinstance(expr.op, sub_t)
          Severity: Major
          Found in src/renamer.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return
            Severity: Major
            Found in src/output/c.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return leq_t(expr.op.op1.pluck(), expr.op.op2.pluck())
              Severity: Major
              Found in src/filters/simplify_expressions.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return
                Severity: Major
                Found in src/output/c.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return False
                  Severity: Major
                  Found in src/pruner.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return False
                    Severity: Major
                    Found in src/renamer.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return
                      Severity: Major
                      Found in src/output/c.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return
                        Severity: Major
                        Found in src/output/c.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return
                          Severity: Major
                          Found in src/output/c.py - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                              return
                            Severity: Major
                            Found in src/filters/simplify_expressions.py - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                    return
                              Severity: Major
                              Found in src/output/c.py - About 30 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language