Maroc-OS/decompiler

View on GitHub

Showing 2,968 of 2,968 total issues

Avoid too many return statements within this function.
Open

        return True
Severity: Major
Found in src/renamer.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return False
    Severity: Major
    Found in src/renamer.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return True
      Severity: Major
      Found in src/renamer.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return True
        Severity: Major
        Found in src/renamer.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return
          Severity: Major
          Found in src/output/c.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return False
            Severity: Major
            Found in src/pruner.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return False
              Severity: Major
              Found in src/renamer.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return False
                Severity: Major
                Found in src/pruner.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return lower_t(expr.op1.op1.pluck(), expr.op1.op2.pluck())
                  Severity: Major
                  Found in src/filters/simplify_expressions.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return
                    Severity: Major
                    Found in src/output/c.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return
                      Severity: Major
                      Found in src/output/c.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return eq_t(expr.op.op1.pluck(), neg_t(expr.op.op2.pluck()))
                        Severity: Major
                        Found in src/filters/simplify_expressions.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return cls(expr.op1.op1.pluck(), expr.op1.op2.pluck())
                          Severity: Major
                          Found in src/filters/simplify_expressions.py - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                  return
                            Severity: Major
                            Found in src/output/c.py - About 30 mins to fix

                              Similar blocks of code found in 4 locations. Consider refactoring.
                              Open

                                def no_index_eq(self, other):
                                  return isinstance(other, self.__class__) and self.where == other.where
                              Severity: Major
                              Found in src/expressions.py and 3 other locations - About 30 mins to fix
                              src/expressions.py on lines 244..245
                              src/expressions.py on lines 287..288
                              src/statements.py on lines 277..278

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 32.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                    expr = regloc_t(op.reg, self.get_register_size(op.reg), name=self.get_regname(op.reg))
                              Severity: Minor
                              Found in src/host/ida/dis/intel.py and 1 other location - About 30 mins to fix
                              src/host/ida/dis/intel.py on lines 133..133

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 32.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                    expr = regloc_t(op.reg, self.get_register_size(op.reg), name=self.get_regname(op.reg))
                              Severity: Minor
                              Found in src/host/ida/dis/intel.py and 1 other location - About 30 mins to fix
                              src/host/ida/dis/intel.py on lines 126..126

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 32.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 4 locations. Consider refactoring.
                              Open

                                def no_index_eq(self, other):
                                  return isinstance(other, self.__class__) and self.where == other.where
                              Severity: Major
                              Found in src/expressions.py and 3 other locations - About 30 mins to fix
                              src/expressions.py on lines 244..245
                              src/expressions.py on lines 343..344
                              src/statements.py on lines 277..278

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 32.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                  left = [this.container[-1].true.value, this.container[-1].false.value]
                              Severity: Minor
                              Found in src/filters/controlflow.py and 1 other location - About 30 mins to fix
                              src/filters/controlflow.py on lines 199..199

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 32.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 4 locations. Consider refactoring.
                              Open

                                def __eq__(self, other):
                                  return isinstance(other, self.__class__) and self.expr == other.expr
                              Severity: Major
                              Found in src/statements.py and 3 other locations - About 30 mins to fix
                              src/expressions.py on lines 244..245
                              src/expressions.py on lines 287..288
                              src/expressions.py on lines 343..344

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 32.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Severity
                              Category
                              Status
                              Source
                              Language