Sign upLogin

MinnPost/object-sync-for-salesforce

View on GitHub
Star

Showing 364 of 364 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function set( $operation, $object_type = '', $fieldmap_id = '', $value = '', $expiration = 0 ) {
        // generate the option key parameters.
        $params = array(
            'operation'   => $operation,
            'object_type' => $object_type,
Severity: Major
Found in classes/class-object-sync-sf-sync-transients.php and 1 other location - About 2 hrs to fix
classes/class-object-sync-sf-pull-options.php on lines 99..127

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function delete_called_from_salesforce has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    private function delete_called_from_salesforce( $sf_sync_trigger, $synced_object, $wordpress_id_field_name, $seconds, $mapping_objects ) {

        $salesforce_mapping = $synced_object['mapping'];
        $mapping_object     = $synced_object['mapping_object'];
Severity: Minor
Found in classes/class-object-sync-sf-salesforce-pull.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function legacy_option_upgrade( $operation, $object_type = '', $fieldmap_id = '', $value = '', $autoload = true ) {
        $result       = false;
        $legacy_value = $this->legacy_get( $operation, $object_type, $fieldmap_id );
        if ( false !== $legacy_value ) {
            // generate the option key parameters.
Severity: Major
Found in classes/class-object-sync-sf-pull-options.php and 1 other location - About 2 hrs to fix
classes/class-object-sync-sf-sync-transients.php on lines 130..148

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function legacy_transient_upgrade( $operation, $object_type = '', $fieldmap_id = '', $value = '', $expiration = 0 ) {
        $result       = false;
        $legacy_value = $this->legacy_get( $operation, $object_type, $fieldmap_id );
        if ( false !== $legacy_value ) {
            // generate the option key parameters.
Severity: Major
Found in classes/class-object-sync-sf-sync-transients.php and 1 other location - About 2 hrs to fix
classes/class-object-sync-sf-pull-options.php on lines 140..158

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function show_salesforce_user_fields has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function show_salesforce_user_fields( $user ) {
        $get_data = filter_input_array( INPUT_GET, FILTER_SANITIZE_SPECIAL_CHARS );
        if ( true === $this->check_wordpress_admin_permissions() ) {
            $mappings = $this->mappings->load_all_by_wordpress( 'user', $user->ID );
            $fieldmap = $this->mappings->get_fieldmaps(
Severity: Minor
Found in classes/class-object-sync-sf-admin.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function attachment_update has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    private function attachment_update( $attachment_id, $params, $id_field = 'ID' ) {
        $content              = array();
        $content[ $id_field ] = $attachment_id;
        foreach ( $params as $key => $value ) {
            if ( 'wp_insert_attachment' === $value['method_modify'] ) { // Should also be insert attachment maybe.
Severity: Minor
Found in classes/class-object-sync-sf-wordpress.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if ( 1 === $salesforce_pushing ) {
                $transients_to_delete[ $fieldmap_key ]['transients'][] = $mapping_object_id_transient;
                if ( true === $this->debug ) {
                    // create log entry for failed pull.
                    $status = 'debug';
Severity: Major
Found in classes/class-object-sync-sf-salesforce-pull.php and 1 other location - About 2 hrs to fix
classes/class-object-sync-sf-salesforce-push.php on lines 573..597

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                if ( 1 === $salesforce_pulling ) {
                    // if it is pulling, delete the transient and continue on through the loop.
                    // we need to either do this for every individual mapping object, or only do it when all the mapping objects are done.
                            $transients_to_delete[ $fieldmap_key ]['transients'][] = $mapping_object_id_transient;
                    if ( true === $this->debug ) {
Severity: Major
Found in classes/class-object-sync-sf-salesforce-push.php and 1 other location - About 2 hrs to fix
classes/class-object-sync-sf-salesforce-pull.php on lines 1380..1402

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 136.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method update_called_from_salesforce has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function update_called_from_salesforce( $sf_sync_trigger, $synced_object, $params, $wordpress_id_field_name, $seconds ) {

        $salesforce_mapping = $synced_object['mapping'];
        $mapping_object     = $synced_object['mapping_object'];
        $object             = $synced_object['salesforce_object'];
Severity: Major
Found in classes/class-object-sync-sf-salesforce-pull.php - About 2 hrs to fix

    Method object_fields has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function object_fields( $object_name, $id_field, $content_table, $content_methods, $meta_table, $meta_methods, $where, $ignore_keys = array() ) {
        // These two queries load all the fields from the specified object unless they have been specified as ignore fields.
        // They also load the fields that are meta_keys from the specified object's meta table.
        // Maybe a box for a custom query, since custom fields get done in so many ways.
        // Eventually this would be the kind of thing we could use fields api for, if it ever gets done.
    Severity: Major
    Found in classes/class-object-sync-sf-wordpress.php - About 2 hrs to fix

      Method wordpress_salesforce_tables has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function wordpress_salesforce_tables() {

        $charset_collate = $this->wpdb->get_charset_collate();

        $field_map_table = $this->wpdb->prefix . 'object_sync_sf_field_map';
      Severity: Major
      Found in classes/class-object-sync-sf-activate.php - About 2 hrs to fix

        Function manual_push has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            public function manual_push( $object_type, $wordpress_id, $http_method ) {
        $object = $this->wordpress->get_wordpress_object_data( $object_type, $wordpress_id );
        // run the WordPress trigger that corresponds to the HTTP method.
        switch ( $http_method ) {
            case 'POST':
        Severity: Minor
        Found in classes/class-object-sync-sf-salesforce-push.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function post_create has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            private function post_create( $params, $id_field = 'ID', $post_type = 'post' ) {
        // Load all params with a method_modify of the object structure's content_method into $content.
        $content   = array();
        $structure = $this->get_wordpress_table_structure( $post_type );
        foreach ( $params as $key => $value ) {
        Severity: Minor
        Found in classes/class-object-sync-sf-wordpress.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            private function remove_upgradeable_key( $key ) {
        $keys      = $this->get_upgradeable_keys();
        $array_key = array_search( $key, $keys, true );
        if ( false !== $array_key ) {
            unset( $keys[ $array_key ] );
        Severity: Major
        Found in classes/class-object-sync-sf-sync-transients.php and 1 other location - About 2 hrs to fix
        classes/class-object-sync-sf-pull-options.php on lines 280..294

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 132.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            private function remove_upgradeable_key( $key ) {
        $keys      = $this->get_upgradeable_keys();
        $array_key = array_search( $key, $keys, true );
        if ( false !== $array_key ) {
            unset( $keys[ $array_key ] );
        Severity: Major
        Found in classes/class-object-sync-sf-pull-options.php and 1 other location - About 2 hrs to fix
        classes/class-object-sync-sf-sync-transients.php on lines 269..283

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 132.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Object_Sync_Sf_Logging has 23 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Object_Sync_Sf_Logging extends WP_Logging {

    /**
     * Current version of the plugin
     *
        Severity: Minor
        Found in classes/class-object-sync-sf-logging.php - About 2 hrs to fix

          Object_Sync_Sf_Mapping has 23 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class Object_Sync_Sf_Mapping {

    /**
     * Current version of the plugin
     *
          Severity: Minor
          Found in classes/class-object-sync-sf-mapping.php - About 2 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                        if ( true === $this->debug ) {
                                // create log entry for failed pull.
                                $status = 'debug';
                                $title  = sprintf(
                                    // translators: placeholders are: 1) the log status, 2) the Salesforce ID.
            Severity: Major
            Found in classes/class-object-sync-sf-salesforce-pull.php and 1 other location - About 2 hrs to fix
            classes/class-object-sync-sf-salesforce-pull.php on lines 516..533

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 130.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                    if ( true === $this->debug ) {
                            // create log entry for successful pull.
                            $status = 'debug';
                            $title  = sprintf(
                                // translators: placeholders are: 1) the log status, 2) the Salesforce ID.
            Severity: Major
            Found in classes/class-object-sync-sf-salesforce-pull.php and 1 other location - About 2 hrs to fix
            classes/class-object-sync-sf-salesforce-pull.php on lines 455..472

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 130.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function get_pull_query has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
            Open

                private function get_pull_query( $type, $salesforce_mapping = array(), $force_current_offset = false ) {
        // we need to determine what to do with saved queries. this is what we currently do but it doesn't work.
        // check if we have a stored next query to run for this type. if so, unserialize it so we have an object.
        $pull_query_running = $this->pull_options->get( 'current_query', $type, $salesforce_mapping['id'], '' );
        if ( '' !== $pull_query_running ) {
            Severity: Minor
            Found in classes/class-object-sync-sf-salesforce-pull.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language