Issues - Mirantis/virtlet

Avoid deeply nested control flow statements.
Open

                        if err != nil {
                            glog.V(2).Infof("error decoding private key #%d from transport profile %s", i, rule.Transport)
                        } else {
                            privateKey = k
                        }

Found in pkg/imagetranslation/translator.go - About 45 mins to fix

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

/*

Found in pkg/nettools/nettools.go by gofmt

Exclude checks
- Disable engine
- Disable check

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build !linux

Found in pkg/stream/utils_unsupported.go by gofmt

Exclude checks
- Disable engine
- Disable check

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

/*

Found in pkg/utils/waitproc.go by gofmt

Exclude checks
- Disable engine
- Disable check

don't use ALL_CAPS in Go names; use CamelCase
Open

    RTPROT_KERNEL  = 0

Found in pkg/nettools/nettools_unsupported.go by golint

Exclude checks
- Disable engine
- Disable check

exported method TestCommand.Pid should have comment or be unexported
Open

func (tc *TestCommand) Pid() int {

Found in pkg/utils/testing/runprocess.go by golint

Exclude checks
- Disable engine
- Disable check

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build !linux

Found in pkg/utils/netns_unsupported.go by gofmt

Exclude checks
- Disable engine
- Disable check

should replace nextToUseHostdevNo += 1 with nextToUseHostdevNo++
Open

                    nextToUseHostdevNo += 1

Found in cmd/vmwrapper/vmwrapper.go by golint

Exclude checks
- Disable engine
- Disable check

don't use ALL_CAPS in Go names; use CamelCase
Open

    SCOPE_LINK     = 0

Found in pkg/nettools/nettools_unsupported.go by golint

Exclude checks
- Disable engine
- Disable check

type name will be used as fake.FakeDomainConnection by other packages, and that stutters; consider calling this DomainConnection
Open

type FakeDomainConnection struct {

Found in pkg/virt/fake/fake_domain.go by golint

Exclude checks
- Disable engine
- Disable check

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build linux

Found in pkg/fs/fsstat_linux.go by gofmt

Exclude checks
- Disable engine
- Disable check

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build !ignore_autogenerated

Found in pkg/api/virtlet.k8s/v1/zz_generated.deepcopy.go by gofmt

Exclude checks
- Disable engine
- Disable check

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build !linux

Found in pkg/nettools/nettools_unsupported.go by gofmt

Exclude checks
- Disable engine
- Disable check

don't use ALL_CAPS in Go names; use CamelCase
Open

    SCOPE_UNIVERSE = netlink.SCOPE_UNIVERSE

Found in pkg/nettools/nettools_linux.go by golint

Exclude checks
- Disable engine
- Disable check

don't use ALL_CAPS in Go names; use CamelCase
Open

    SCOPE_UNIVERSE = 0

Found in pkg/nettools/nettools_unsupported.go by golint

Exclude checks
- Disable engine
- Disable check

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build !linux

Found in cmd/virtlet/pdeathsig_unsupported.go by gofmt

Exclude checks
- Disable engine
- Disable check

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build !linux

Found in pkg/fs/fs_unsupported.go by gofmt

Exclude checks
- Disable engine
- Disable check

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build !linux

Found in pkg/nettools/tap_unsupported.go by gofmt

Exclude checks
- Disable engine
- Disable check

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build linux

Found in pkg/fs/fs_linux.go by gofmt

Exclude checks
- Disable engine
- Disable check

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build linux

Found in pkg/nettools/nettools_linux.go by gofmt

Exclude checks
- Disable engine
- Disable check

Mirantis/virtlet

Showing 52 of 52 total issues

Avoid deeply nested control flow statements.
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

don't use ALL_CAPS in Go names; use CamelCase
Open

exported method TestCommand.Pid should have comment or be unexported
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

should replace nextToUseHostdevNo += 1 with nextToUseHostdevNo++
Open

don't use ALL_CAPS in Go names; use CamelCase
Open

type name will be used as fake.FakeDomainConnection by other packages, and that stutters; consider calling this DomainConnection
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

don't use ALL_CAPS in Go names; use CamelCase
Open

don't use ALL_CAPS in Go names; use CamelCase
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Severity

Category

Status

Source

Language

Mirantis/virtlet

Showing 52 of 52 total issues

Avoid deeply nested control flow statements. Open

Your code does not pass gofmt in 1 place. Go fmt your code! Open

Your code does not pass gofmt in 1 place. Go fmt your code! Open

Your code does not pass gofmt in 1 place. Go fmt your code! Open

don't use ALL_CAPS in Go names; use CamelCase Open

exported method TestCommand.Pid should have comment or be unexported Open

Your code does not pass gofmt in 1 place. Go fmt your code! Open

should replace nextToUseHostdevNo += 1 with nextToUseHostdevNo++ Open

don't use ALL_CAPS in Go names; use CamelCase Open

type name will be used as fake.FakeDomainConnection by other packages, and that stutters; consider calling this DomainConnection Open

Your code does not pass gofmt in 1 place. Go fmt your code! Open

Your code does not pass gofmt in 1 place. Go fmt your code! Open

Your code does not pass gofmt in 1 place. Go fmt your code! Open

don't use ALL_CAPS in Go names; use CamelCase Open

don't use ALL_CAPS in Go names; use CamelCase Open

Your code does not pass gofmt in 1 place. Go fmt your code! Open

Your code does not pass gofmt in 1 place. Go fmt your code! Open

Your code does not pass gofmt in 1 place. Go fmt your code! Open

Your code does not pass gofmt in 1 place. Go fmt your code! Open

Your code does not pass gofmt in 1 place. Go fmt your code! Open

Severity

Category

Status

Source

Language

Avoid deeply nested control flow statements.
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

don't use ALL_CAPS in Go names; use CamelCase
Open

exported method TestCommand.Pid should have comment or be unexported
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

should replace nextToUseHostdevNo += 1 with nextToUseHostdevNo++
Open

don't use ALL_CAPS in Go names; use CamelCase
Open

type name will be used as fake.FakeDomainConnection by other packages, and that stutters; consider calling this DomainConnection
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

don't use ALL_CAPS in Go names; use CamelCase
Open

don't use ALL_CAPS in Go names; use CamelCase
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

Your code does not pass gofmt in 1 place. Go fmt your code!
Open