Sign upLogin

Mirantis/virtlet

View on GitHub
Star

Showing 52 of 52 total issues

type name will be used as fake.FakeStorageVolume by other packages, and that stutters; consider calling this StorageVolume
Open

type FakeStorageVolume struct {
Severity: Minor
Found in pkg/virt/fake/fake_storage.go by golint

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build linux
Severity: Minor
Found in cmd/virtlet/pdeathsig_linux.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build !linux
Severity: Minor
Found in pkg/utils/netns_unsupported.go by gofmt

exported function EncodePEMCert should have comment or be unexported
Open

func EncodePEMCert(cert *x509.Certificate) string {
Severity: Minor
Found in pkg/utils/testing/https.go by golint

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build linux
Severity: Minor
Found in pkg/utils/netns_linux.go by gofmt

should replace nextToUseHostdevNo += 1 with nextToUseHostdevNo++
Open

                    nextToUseHostdevNo += 1
Severity: Minor
Found in cmd/vmwrapper/vmwrapper.go by golint

don't use ALL_CAPS in Go names; use CamelCase
Open

    FAMILY_V4      = 0
Severity: Minor
Found in pkg/nettools/nettools_unsupported.go by golint

exported function GenerateCert should have comment or be unexported
Open

func GenerateCert(t *testing.T, isCA bool, host string, signer *x509.Certificate, key *rsa.PrivateKey) (*x509.Certificate, *rsa.PrivateKey) {
Severity: Minor
Found in pkg/utils/testing/https.go by golint

type name will be used as fake.FakeDomain by other packages, and that stutters; consider calling this Domain
Open

type FakeDomain struct {
Severity: Minor
Found in pkg/virt/fake/fake_domain.go by golint

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

/*
Severity: Minor
Found in pkg/client/clientset/versioned/scheme/register.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build !linux
Severity: Minor
Found in pkg/nettools/tap_unsupported.go by gofmt

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build linux
Severity: Minor
Found in pkg/nsfix/nsfix_linux.go by gofmt

don't use ALL_CAPS in Go names; use CamelCase
Open

    SCOPE_UNIVERSE = 0
Severity: Minor
Found in pkg/nettools/nettools_unsupported.go by golint

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build !linux
Severity: Minor
Found in pkg/stream/utils_unsupported.go by gofmt

exported func NewClient returns unexported type *cni.client, which can be annoying to use
Open

func NewClient(pluginsDir, configsDir string) (*client, error) {
Severity: Minor
Found in pkg/cni/client.go by golint

don't use ALL_CAPS in Go names; use CamelCase
Open

    SCOPE_LINK     = netlink.SCOPE_LINK
Severity: Minor
Found in pkg/nettools/nettools_linux.go by golint

Your code does not pass gofmt in 1 place. Go fmt your code!
Open

// +build !linux
Severity: Minor
Found in pkg/nettools/nettools_unsupported.go by gofmt

don't use ALL_CAPS in Go names; use CamelCase
Open

    FAMILY_ALL     = 0
Severity: Minor
Found in pkg/nettools/nettools_unsupported.go by golint

type name will be used as fake.FakeStoragePool by other packages, and that stutters; consider calling this StoragePool
Open

type FakeStoragePool struct {
Severity: Minor
Found in pkg/virt/fake/fake_storage.go by golint

2: cannot find package "github.com/Mirantis/virtlet/pkg/flexvolume" in any of:
Open

    "github.com/Mirantis/virtlet/pkg/flexvolume"
Severity: Minor
Found in cmd/flexvolume_driver/flexvolume_driver.go by govet
Severity
Category
Status
Source
Language