Mirocow/yii2-elasticsearch

View on GitHub
src/components/indexes/ModelPopulate.php

Summary

Maintainability
D
2 days
Test Coverage

Function createModels has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

    protected function createModels($rows)
    {
        $models = [];
        if ($this->asArray) {
            if ($this->indexBy === null) {
Severity: Minor
Found in src/components/indexes/ModelPopulate.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function search has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

    public function search()
    {
        $items = $this->result;

        if (!($items instanceof SearchHitIterator)) {
Severity: Minor
Found in src/components/indexes/ModelPopulate.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createModels has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function createModels($rows)
    {
        $models = [];
        if ($this->asArray) {
            if ($this->indexBy === null) {
Severity: Major
Found in src/components/indexes/ModelPopulate.php - About 2 hrs to fix

    Function populate has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public function populate()
        {
            $rows = &$this->result;
    
            if ($this->indexBy === null) {
    Severity: Minor
    Found in src/components/indexes/ModelPopulate.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method search has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function search()
        {
            $items = $this->result;
    
            if (!($items instanceof SearchHitIterator)) {
    Severity: Minor
    Found in src/components/indexes/ModelPopulate.php - About 1 hr to fix

      Method populate has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function populate()
          {
              $rows = &$this->result;
      
              if ($this->indexBy === null) {
      Severity: Minor
      Found in src/components/indexes/ModelPopulate.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status