Sign upLogin

Mirroar/hivemind

View on GitHub
Star
src/process/strategy/scout.ts

Summary

Maintainability
F
5 days
Test Coverage

Function calculateExpansionScore has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

    calculateExpansionScore(roomName: string) {
        const result: ExpansionScore = {
            score: 0,
            reasons: {},
            addScore(amount: number, reason: string) {
Severity: Minor
Found in src/process/strategy/scout.ts - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File scout.ts has 398 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* global RoomPosition OBSERVER_RANGE SOURCE_ENERGY_CAPACITY */

import Process from 'process/process';
import hivemind from 'hivemind';
import interShard from 'intershard';
Severity: Minor
Found in src/process/strategy/scout.ts - About 5 hrs to fix

    Function calculateRoomPriorities has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        calculateRoomPriorities(roomName: string) {
        const roomIntel = getRoomIntel(roomName);
        const info = Memory.strategy.roomList[roomName];

        info.scoutPriority = 0;
    Severity: Minor
    Found in src/process/strategy/scout.ts - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function calculateExpansionScore has 93 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        calculateExpansionScore(roomName: string) {
        const result: ExpansionScore = {
            score: 0,
            reasons: {},
            addScore(amount: number, reason: string) {
    Severity: Major
    Found in src/process/strategy/scout.ts - About 3 hrs to fix

      Function calculateRoomPriorities has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          calculateRoomPriorities(roomName: string) {
        const roomIntel = getRoomIntel(roomName);
        const info = Memory.strategy.roomList[roomName];

        info.scoutPriority = 0;
      Severity: Major
      Found in src/process/strategy/scout.ts - About 2 hrs to fix

        Function addAdjacentRooms has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            addAdjacentRooms(roomName: string, openList: Record<string, RoomListEntry>, closedList: Record<string, boolean>) {
        const info = openList[roomName];
        if (info.range >= (Memory.hivemind.maxScoutDistance || 7)) return;

        const roomIntel = getRoomIntel(roomName);
        Severity: Minor
        Found in src/process/strategy/scout.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function generateScoutTargets has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            generateScoutTargets() {
        const roomList = Memory.strategy.roomList || {};

        const openList = this.getScoutOrigins();
        const closedList: Record<string, boolean> = {};
        Severity: Minor
        Found in src/process/strategy/scout.ts - About 1 hr to fix

          Function getHarvestRoomScore has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              getHarvestRoomScore(roomName: string, forOwnedRoom = false) {
        const roomIntel = getRoomIntel(roomName);

        // We can't harvest from highway rooms.
        if (isHighway(roomName)) return 0;
          Severity: Minor
          Found in src/process/strategy/scout.ts - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function calculateHarvestScore has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              calculateHarvestScore(roomName: string) {
        const info = Memory.strategy.roomList[roomName];

        if (info.range === 0 || info.range > hivemind.settings.get('maxRemoteMineRoomDistance')) return 0;
          Severity: Minor
          Found in src/process/strategy/scout.ts - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              run() {
        hivemind.log('strategy').info('Running scout process...');

        Memory.strategy.roomList = this.generateScoutTargets();
        this.generateMineralStatus();
          Severity: Minor
          Found in src/process/strategy/scout.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function generateScoutTargets has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              generateScoutTargets() {
        const roomList = Memory.strategy.roomList || {};

        const openList = this.getScoutOrigins();
        const closedList: Record<string, boolean> = {};
          Severity: Minor
          Found in src/process/strategy/scout.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getClosestObserver has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              getClosestObserver(roomName: string): StructureObserver {
        let bestObserver: StructureObserver = null;
        for (const observer of this.observers) {
            const roomDist = Game.map.getRoomLinearDistance(observer.room.name, roomName);
            if (roomDist > OBSERVER_RANGE) continue;
          Severity: Minor
          Found in src/process/strategy/scout.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (const portal of roomIntel.getRoomPortals()) {
            if (openList[portal] || closedList[portal]) continue;

            const roomIntel = getRoomIntel(portal);
            const roomIsSafe = !roomIntel.isClaimed() || (roomIntel.memory.reservation && roomIntel.memory.reservation.username === 'Invader');
          Severity: Major
          Found in src/process/strategy/scout.ts and 1 other location - About 5 hrs to fix
          src/process/strategy/scout.ts on lines 603..614

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 141.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (const exit of _.values<string>(roomIntel.getExits())) {
            if (openList[exit] || closedList[exit]) continue;

            const roomIntel = getRoomIntel(exit);
            const roomIsSafe = !roomIntel.isClaimed() || (roomIntel.memory.reservation && roomIntel.memory.reservation.username === 'Invader');
          Severity: Major
          Found in src/process/strategy/scout.ts and 1 other location - About 5 hrs to fix
          src/process/strategy/scout.ts on lines 616..627

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 141.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status