Sign upLogin

Mirroar/hivemind

View on GitHub
Star
src/room-defense.ts

Summary

Maintainability
C
1 day
Test Coverage

Function getEnemyStrength has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getEnemyStrength(): EnemyStrength {
        return cache.inObject(this.room, 'getEnemyStrength', 1, () => {
            let attackStrength = 0;
            let healStrength = 0;
            let totalStrength = 0;
Severity: Minor
Found in src/room-defense.ts - About 1 hr to fix

    Function openRampartsToFriendlies has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        openRampartsToFriendlies() {
        if (_.size(this.room.enemyCreeps) === 0) {
            if (this.memory.lastActivity && Game.time - this.memory.lastActivity > 10) {
                // Close ramparts after last friendly leaves the room for a while.
                const ramparts = this.room.myStructuresByType[STRUCTURE_RAMPART];
    Severity: Minor
    Found in src/room-defense.ts - About 1 hr to fix

      Function drawDebug has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          drawDebug() {
        const dangerMatrix = getDangerMatrix(this.roomName);
        const visual = this.room.visual;
        if (!visual || hivemind.settings.get('disableRoomVisuals')) return;
      Severity: Minor
      Found in src/room-defense.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function recordCreepStatus has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          recordCreepStatus(creep: Creep) {
        // @todo Detect killed creeps as resources we've gained.

        if (!this.memory.creepStatus[creep.id]) {
            const store = {};
      Severity: Minor
      Found in src/room-defense.ts - About 1 hr to fix

        Function recordCreepStatus has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            recordCreepStatus(creep: Creep) {
        // @todo Detect killed creeps as resources we've gained.

        if (!this.memory.creepStatus[creep.id]) {
            const store = {};
        Severity: Minor
        Found in src/room-defense.ts - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                    if (part.type === TOUGH) {
                                partPower = 100;
                                boostPower = 1 / (effect.damage || 1);
                            }
        Severity: Major
        Found in src/room-defense.ts - About 45 mins to fix

          Avoid too many return statements within this function.
          Open

                      return ENEMY_STRENGTH_DEADLY;
          Severity: Major
          Found in src/room-defense.ts - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (dangerMatrix.get(x, y) === 1) {
                    visual.rect(x - 0.4, y - 0.4, 0.8, 0.8, {
                        fill: '#af6060',
                        opacity: 0.3,
                    });
            Severity: Minor
            Found in src/room-defense.ts and 1 other location - About 55 mins to fix
            src/room-defense.ts on lines 90..95

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (dangerMatrix.get(x, y) === 2) {
                    visual.rect(x - 0.3, y - 0.3, 0.6, 0.6, {
                        fill: '#6060af',
                        opacity: 0.3,
                    });
            Severity: Minor
            Found in src/room-defense.ts and 1 other location - About 55 mins to fix
            src/room-defense.ts on lines 83..88

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status