ewallet/src/Adapters/RabbitMq/Application/Messaging/AmqpMessageConsumer.php
Avoid using static access to class '\Closure' in method 'consume'. Open
Open
Closure::fromCallable(function (AMQPMessage $message): void {
$this->callback($message);
})- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid unused local variables such as '$idle'. Open
Open
$this->channel->wait(null, false, $idle = 30); // Only wait 30 seconds- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid using Adapters\RabbitMq\Application\Messaging\count() function in while loops. Open
Open
while (count($this->channel->callbacks)) {
if ($this->consumed) {
break;
}
$this->channel->wait(null, false, $idle = 30); // Only wait 30 seconds- Read upRead up
- Exclude checks
CountInLoopExpression
Since: 2.7.0
Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.
Example
class Foo {
public function bar()
{
$array = array();
for ($i = 0; count($array); $i++) {
// ...
}
}
}