Sign upLogin

MontealegreLuis/php-testing-tools

View on GitHub
Star

Showing 68 of 68 total issues

Avoid using static access to class '\Closure' in method 'consume'.
Open

            Closure::fromCallable(function (AMQPMessage $message): void {
                $this->callback($message);
            })
Severity: Minor
Found in ewallet/src/Adapters/RabbitMq/Application/Messaging/AmqpMessageConsumer.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Ewallet\Memberships\InvalidTransfer' in method 'receiveDeposit'.
Open

            throw InvalidTransfer::with($amount);
Severity: Minor
Found in ewallet/src/Ewallet/Memberships/Member.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Ewallet\Memberships\InsufficientFunds' in method 'withdraw'.
Open

            throw InsufficientFunds::withdrawing($amount, $this->balance);
Severity: Minor
Found in ewallet/src/Ewallet/Memberships/Account.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Ewallet\Memberships\Account' in method 'withAccountBalance'.
Open

        return new Member($memberId, $name, $email, Account::withBalance($amount));
Severity: Minor
Found in ewallet/src/Ewallet/Memberships/Member.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$input'.
Open

    protected function execute(InputInterface $input, OutputInterface $output): int
Severity: Minor
Found in ui/messaging/src/Ui/Console/Commands/NotifyTransferByEmailCommand.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$output'.
Open

    public function execute(InputInterface $input, OutputInterface $output): int
Severity: Minor
Found in ui/console/src/UI/Console/Commands/TransferFundsCommand.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid using static access to class '\Doctrine\DBAL\Types\ConversionException' in method 'convertToDatabaseValue'.
Open

        throw ConversionException::conversionFailed((string) $value, Types::GUID);
Severity: Minor
Found in ewallet/src/Adapters/Doctrine/Ewallet/Types/UuidType.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Dotenv\Dotenv' in method 'load'.
Open

            $environment = Dotenv::createImmutable($basePath->absolutePath());
Severity: Minor
Found in ewallet/src/Application/Environment.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Closure' in method 'executeAtomically'.
Open

        return $this->entityManager->transactional(Closure::fromCallable($operation));
Severity: Minor
Found in ewallet/src/Adapters/Doctrine/Application/Services/DoctrineSession.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused parameters such as '$type'.
Open

                    fn ($visitor, CarbonImmutable $dateTime, array $type): string => $dateTime->format('Y-m-d H:i:s')
Severity: Minor
Found in ewallet/src/Adapters/JmsSerializer/Application/DomainEvents/JsonSerializer.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method assignMessageByPath uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $errors = &$errors[$key];
            }
Severity: Minor
Found in ewallet/src/Application/InputValidation/ErrorMessages.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\Slim\Factory\AppFactory' in method 'createFromContainer'.
Open

        $app = AppFactory::createFromContainer($container);
Severity: Minor
Found in ui/web/src/Framework/Slim/ApplicationFactory.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Doctrine\ORM\Tools\Setup' in method 'create'.
Open

        $configuration = Setup::createXMLMetadataConfiguration(
            $config['mapping_dirs'],
            $config['dev_mode'],
            $config['proxy_dir']
        );
Severity: Minor
Found in ewallet/src/Adapters/Doctrine/EntityManagerFactory.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'setPath'.
Open

        Assert::true($path->isReadable(), '%s is not readable a directory');
Severity: Minor
Found in ewallet/src/Application/BasePath.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'setName'.
Open

        Assert::notEmpty($name);
Severity: Minor
Found in ewallet/src/Ewallet/Memberships/Member.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Webmozart\Assert\Assert' in method 'setAddress'.
Open

        Assert::email($address, "{$address} is not a valid email address");
Severity: Minor
Found in ewallet/src/Ewallet/Memberships/Email.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Application\Messaging\InvalidPublishedMessageToTrack' in method 'track'.
Open

            throw InvalidPublishedMessageToTrack::isNotTheMostRecent($mostRecentPublishedMessage, $currentMessage);
Severity: Minor
Found in ewallet/src/Adapters/Doctrine/Application/Messaging/MessageTrackerRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Doctrine\DBAL\Types\Type' in method 'create'.
Open

                Type::addType($type, $class);
Severity: Minor
Found in ewallet/src/Adapters/Doctrine/EntityManagerFactory.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Ewallet\Memberships\UnknownMember' in method 'with'.
Open

            throw UnknownMember::identifiedBy($memberId);
Severity: Minor
Found in ewallet/src/Adapters/Doctrine/Ewallet/Memberships/MembersRepository.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Closure' in method 'execute'.
Open

        return $this->session->executeAtomically(Closure::fromCallable($operation));
Severity: Minor
Found in ewallet/src/Application/Services/ProvidesTransactionalOperations.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language