Sign upLogin

Narazaka/xlsx2seed.js

View on GitHub
Star

Showing 9 of 9 total issues

Function _get_data has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

  _get_data(require_version = '') {
    const row_indexes = this._row_indexes[require_version] = [] as number[];
    const rows = [];
    const version_column_index = this.version_column_index;
    const require_version_range = `>= ${require_version}`;
Severity: Minor
Found in src/lib/xlsx2seed.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File xlsx2seed.ts has 323 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

import * as jsyaml from 'js-yaml';
import * as semver from 'semver';
import * as XLSX from 'xlsx';
Severity: Minor
Found in src/lib/xlsx2seed.ts - About 3 hrs to fix

    Function _get_data has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _get_data(require_version = '') {
    const row_indexes = this._row_indexes[require_version] = [] as number[];
    const rows = [];
    const version_column_index = this.version_column_index;
    const require_version_range = `>= ${require_version}`;
    Severity: Minor
    Found in src/lib/xlsx2seed.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        data(require_version = '') {
    if (!this._data[require_version]) this._get_data(require_version);

    return this._data[require_version];
  }
      Severity: Minor
      Found in src/lib/xlsx2seed.ts and 1 other location - About 40 mins to fix
      src/lib/xlsx2seed.ts on lines 137..141

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        row_indexes(require_version = '') {
    if (!this._row_indexes[require_version]) this._get_data(require_version);

    return this._row_indexes[require_version];
  }
      Severity: Minor
      Found in src/lib/xlsx2seed.ts and 1 other location - About 40 mins to fix
      src/lib/xlsx2seed.ts on lines 174..178

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function get_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function get_config(program: Program) { // tslint:disable-line no-shadowed-variable
  try {
    if (program.configContent) {
      return jsyaml.load(program.configContent) as Xlsx2SeedSheetConfig;
    } else {
      Severity: Minor
      Found in src/bin/xlsx2seed.ts - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          return fso.new(directory).new((name ? name : this.sheet_name) + extension)
      .writeFile(this.as_yaml());
      Severity: Minor
      Found in src/lib/xlsx2seed.ts and 1 other location - About 35 mins to fix
      src/lib/xlsx2seed.ts on lines 315..316

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          fso.new(directory).new((name ? name : this.sheet_name) + extension)
      .writeFileSync(this.as_yaml());
      Severity: Minor
      Found in src/lib/xlsx2seed.ts and 1 other location - About 35 mins to fix
      src/lib/xlsx2seed.ts on lines 309..310

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function _set_column_info has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        _set_column_info() {
    const column_names = [];
    const column_indexes = [];
    for (let column_index = 0; column_index <= this.max_column_index; ++column_index) {
      const address = XLSX.utils.encode_cell({c: column_index, r: this.column_names_row});
      Severity: Minor
      Found in src/lib/xlsx2seed.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language