Sign upLogin

NatLibFi/Skosmos

View on GitHub
Star

Showing 1,049 of 1,049 total issues

RestController has 35 functions (exceeds 20 allowed). Consider refactoring.
Open

class RestController extends Controller
{
    /* supported MIME types that can be used to return RDF data */
    public const SUPPORTED_FORMATS = 'application/rdf+xml text/turtle application/ld+json application/json application/marcxml+xml';
    /* context array template */
Severity: Minor
Found in src/controller/RestController.php - About 4 hrs to fix

    Method generateConceptInfoQuery has 111 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function generateConceptInfoQuery($uris, $arrayClass, $vocabs)
    {
        $gcl = $this->graphClause;
        $fcl = empty($vocabs) ? '' : $this->generateFromClause($vocabs);
        $values = $this->formatValues('?uri', $uris, 'uri');
    Severity: Major
    Found in src/model/sparql/GenericSparql.php - About 4 hrs to fix

      File vocab-search.js has 343 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /* global Vue */

const vocabSearch = Vue.createApp({
  data () {
    return {
      Severity: Minor
      Found in resource/js/vocab-search.js - About 4 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        tabHierApp.directive('click-tab-hierarchy', {
  beforeMount: (el, binding) => {
    el.clickTabEvent = event => {
      binding.value() // calling the method given as the attribute value (handleClickHierarchyEvent)
    }
        Severity: Major
        Found in resource/js/tab-hierarchy.js and 1 other location - About 4 hrs to fix
        resource/js/tab-alpha.js on lines 154..164

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        tabAlphaApp.directive('click-tab-alphabetical', {
  beforeMount: (el, binding) => {
    el.clickTabEvent = event => {
      binding.value() // calling the method given as the attribute value (loadLetters)
    }
        Severity: Major
        Found in resource/js/tab-alpha.js and 1 other location - About 4 hrs to fix
        resource/js/tab-hierarchy.js on lines 217..227

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 119.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        GlobalConfig has 33 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class GlobalConfig extends BaseConfig
{
    /** Cache reference */
    private $cache;
    /** Location of the configuration file. Used for caching. */
        Severity: Minor
        Found in src/model/GlobalConfig.php - About 4 hrs to fix

          Function getLabel has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getLabel($lang = '', $fallbackToUri = 'uri')
    {
        if ($this->clang) {
            $lang = $this->clang;
        }
          Severity: Minor
          Found in src/model/ConceptPropertyValue.php - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Request has 30 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class Request
{
    private $lang;
    private $clang;
    private $page;
          Severity: Minor
          Found in src/model/Request.php - About 3 hrs to fix

            Function transformTransitivePropertyResults has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
            Open

                private function transformTransitivePropertyResults($result, $lang, $fallbacklang)
    {
        $ret = array();
        foreach ($result as $row) {
            if (!isset($row->object)) {
            Severity: Minor
            Found in src/model/sparql/GenericSparql.php - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getCollections has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getCollections($includeArrays)
    {
        $groups = array();
        $collections = $this->graph->resourcesMatching('skos:member', $this->resource);
        if (isset($collections)) {
            Severity: Minor
            Found in src/model/Concept.php - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            const children = concept.narrower
                  .sort((a, b) => this.compareConcepts(a, b))
                  .map(c => {
                    return { uri: c.uri, label: c.label, hasChildren: c.hasChildren, children: [], isOpen: false, notation: c.notation }
                  })
            Severity: Major
            Found in resource/js/tab-hierarchy.js and 1 other location - About 3 hrs to fix
            resource/js/tab-hierarchy.js on lines 84..88

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 102.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            const children = concept.narrower
                  .sort((a, b) => this.compareConcepts(a, b))
                  .map(c => {
                    return { uri: c.uri, label: c.label, hasChildren: c.hasChildren, children: [], isOpen: false, notation: c.notation }
                  })
            Severity: Major
            Found in resource/js/tab-hierarchy.js and 1 other location - About 3 hrs to fix
            resource/js/tab-hierarchy.js on lines 120..124

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 102.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Model has 28 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class Model
{
    /** cache for Vocabulary objects */
    private $allVocabularies = null;
    /** cache for Vocabulary objects */
            Severity: Minor
            Found in src/model/Model.php - About 3 hrs to fix

              The class WebController has an overall complexity of 63 which is very high. The configured complexity threshold is 50.
              Open

              class WebController extends Controller
{
    /**
     * Provides access to the templating engine.
     * @property object $twig the twig templating engine.
              Severity: Minor
              Found in src/controller/WebController.php by phpmd

              The class RestController has 35 non-getter- and setter-methods. Consider refactoring RestController to keep number of methods under 25.
              Open

              class RestController extends Controller
{
    /* supported MIME types that can be used to return RDF data */
    public const SUPPORTED_FORMATS = 'application/rdf+xml text/turtle application/ld+json application/json application/marcxml+xml';
    /* context array template */
              Severity: Minor
              Found in src/controller/RestController.php by phpmd

              TooManyMethods

              Since: 0.1

              A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              The default was changed from 10 to 25 in PHPMD 2.3.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanymethods

              The class WebController has 11 public methods. Consider refactoring WebController to keep number of public methods under 10.
              Open

              class WebController extends Controller
{
    /**
     * Provides access to the templating engine.
     * @property object $twig the twig templating engine.
              Severity: Minor
              Found in src/controller/WebController.php by phpmd

              TooManyPublicMethods

              Since: 0.1

              A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

              The class RestController has an overall complexity of 198 which is very high. The configured complexity threshold is 50.
              Open

              class RestController extends Controller
{
    /* supported MIME types that can be used to return RDF data */
    public const SUPPORTED_FORMATS = 'application/rdf+xml text/turtle application/ld+json application/json application/marcxml+xml';
    /* context array template */
              Severity: Minor
              Found in src/controller/RestController.php by phpmd

              The class Concept has an overall complexity of 198 which is very high. The configured complexity threshold is 50.
              Open

              class Concept extends VocabularyDataObject implements Modifiable
{
    /**
     * Stores a label string if the concept has been found through
     * a altLabel/label in a another language than the ui.
              Severity: Minor
              Found in src/model/Concept.php by phpmd

              The class RestController has 24 public methods. Consider refactoring RestController to keep number of public methods under 10.
              Open

              class RestController extends Controller
{
    /* supported MIME types that can be used to return RDF data */
    public const SUPPORTED_FORMATS = 'application/rdf+xml text/turtle application/ld+json application/json application/marcxml+xml';
    /* context array template */
              Severity: Minor
              Found in src/controller/RestController.php by phpmd

              TooManyPublicMethods

              Since: 0.1

              A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

              The class ConceptSearchParameters has an overall complexity of 59 which is very high. The configured complexity threshold is 50.
              Open

              class ConceptSearchParameters
{
    private $config;
    private $request;
    private $vocabs;
              Severity: Minor
              Found in src/model/ConceptSearchParameters.php by phpmd
              Severity
              Category
              Status
              Source
              Language