Sign upLogin

NeroReflex/Gishiki

View on GitHub
Star

Showing 176 of 176 total issues

Function loadRelation has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private static function loadRelation(Column &$column, $className, $propName)
    {
        if (!class_exists($className)) {
            throw new ActiveRecordException("The class $className doesn't exists.", 109);
        }
Severity: Minor
Found in src/Core/MVC/Model/ActiveRecordStructureTrait.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function initTransitionSchema has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private function initTransitionSchema()
    {
        //table must have been already correctly parsed, so I know data is well-formed
        if (!ActiveRecordTables::isRegistered(static::class)) {
            throw new ActiveRecordException("Table definition for the current ActiveRecord object is missing.", 300);
Severity: Minor
Found in src/Core/MVC/Model/ActiveRecordSerializationTrait.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function loadField has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private static function loadField(Table &$table, array $fieldDefinition, $fieldName = null)
    {
        $field = new GenericCollection($fieldDefinition);

        if ((!$field->has('name')) || (!is_string($field->get('name'))) || (strlen($field->get('name')) <= 0)) {
Severity: Minor
Found in src/Core/MVC/Model/ActiveRecordStructureTrait.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '157', column '42').
Open

                $reflectedFunction = new \ReflectionMethod($plugin, $name);
Severity: Minor
Found in src/Core/MVC/Controller/Controller.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '169', column '23').
Open

            throw new \InvalidArgumentException('The encrypted message to be decrypted must be given as a non-empty string');
Severity: Minor
Found in src/Security/Encryption/Asymmetric/Cryptography.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '131', column '23').
Open

            throw new \InvalidArgumentException('The message to be hashed must be given as a valid non-empty string');
Severity: Minor
Found in src/Security/Hashing/Algorithm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '37', column '23').
Open

            throw new \InvalidArgumentException("the connection query must be given as a string");
Severity: Minor
Found in src/Database/Adapters/Utils/ConnectionParser/SqliteConnectionParser.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '62', column '23').
Open

            throw new \InvalidArgumentException('The connection name and the connection details must be given as two string');
Severity: Minor
Found in src/Database/DatabaseManager.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '153', column '32').
Open

        $reflectedAction = new \ReflectionMethod($controllerName, $controllerAction);
Severity: Minor
Found in src/Core/Router/Route.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '180', column '23').
Open

            throw new \InvalidArgumentException('The message to be hashed must be given as a valid non-empty string');
Severity: Minor
Found in src/Security/Hashing/Algorithm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '123', column '23').
Open

            throw new \InvalidArgumentException('The name of the table must be given as a non-empty string');
Severity: Minor
Found in src/Database/Adapters/Utils/PDODatabaseTrait.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '237', column '23').
Open

            throw new \InvalidArgumentException('The name of the table must be given as a non-empty string');
Severity: Minor
Found in src/Database/Adapters/Utils/PDODatabaseTrait.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '101', column '23').
Open

            throw new \InvalidArgumentException('The name of the connection to be retrieved must be given as a string');
Severity: Minor
Found in src/Database/DatabaseManager.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '196', column '23').
Open

            throw new \InvalidArgumentException('The name of a column must be expressed as a non-empty string');
Severity: Minor
Found in src/Database/Schema/Column.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '290', column '23').
Open

            throw new \InvalidArgumentException('The message to be signed must be a non-empty string');
Severity: Minor
Found in src/Security/Encryption/Asymmetric/Cryptography.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '313', column '23').
Open

            throw new \InvalidArgumentException('The hashing algorithm for the PBKDF2 function must be a non-empty string', 2);
Severity: Minor
Found in src/Security/Hashing/Algorithm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '45', column '23').
Open

            throw new \InvalidArgumentException('The collection of properties and nested data must be expressed as an array: '.gettype($items).' given');
Severity: Minor
Found in src/Algorithms/Collections/GenericCollection.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '227', column '20').
Open

        return new \ArrayIterator($this->data);
Severity: Minor
Found in src/Algorithms/Collections/GenericCollection.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '87', column '50').
Open

        $this->loader = (is_null($loader)) ? new \Twig_Loader_Filesystem($templatesDirectory) : $loader;
Severity: Minor
Found in src/Core/MVC/Controller/Plugins/TwigWrapper.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '58', column '23').
Open

            throw new \InvalidArgumentException('The plain message to be encrypted must be given as a non-empty string');
Severity: Minor
Found in src/Security/Encryption/Asymmetric/Cryptography.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Severity
Category
Status
Source
Language