Sign upLogin

Nickersoft/push.js

View on GitHub
Star

Showing 27 of 27 total issues

Parsing error: Unexpected token type
Open

export type GenericNotification = Notification | webkitNotifications;
Severity: Minor
Found in src/types.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: Unexpected token ...
Open

    ...common,
Severity: Minor
Found in rollup.config.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: Unexpected token {
Open

import type { Global } from 'types';
Severity: Minor
Found in src/agents/AbstractAgent.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: Unexpected token {
Open

import type { PushOptions, GenericNotification, Global } from 'types';
Severity: Minor
Found in src/agents/DesktopAgent.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: Unexpected token {
Open

import type { Global, GenericNotification, PushOptions } from 'types';
Severity: Minor
Found in src/agents/WebKitAgent.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Parsing error: Unexpected token {
Open

import type { PluginManifest, GenericNotification, PushOptions } from 'types';
Severity: Minor
Found in src/push/Push.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

The Function constructor is eval.
Open

        var func = new Function(funcStr);
Severity: Minor
Found in src/serviceWorker.js by eslint

Disallow Function Constructor (no-new-func)

It's possible to create functions in JavaScript using the Function constructor, such as:

var x = new Function("a", "b", "return a + b");

This is considered by many to be a bad practice due to the difficulty in debugging and reading these types of functions.

Rule Details

This error is raised to highlight the use of a bad practice. By passing a string to the Function constructor, you are requiring the engine to parse that string much in the way it has to when you call the eval function.

Examples of incorrect code for this rule:

/*eslint no-new-func: "error"*/

var x = new Function("a", "b", "return a + b");
var x = Function("a", "b", "return a + b");

Examples of correct code for this rule:

/*eslint no-new-func: "error"*/

var x = function (a, b) {
    return a + b;
};

When Not To Use It

In more advanced cases where you really need to use the Function constructor. Source: http://eslint.org/docs/rules/

Severity
Category
Status
Source
Language