NodeBB/NodeBB

View on GitHub

Showing 490 of 506 total issues

Function createAdmin has a Cognitive Complexity of 12 (exceeds 10 allowed). Consider refactoring.
Open

async function createAdmin() {
    const User = require('./user');
    const Groups = require('./groups');
    let password;

Severity: Minor
Found in src/install.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

define('forum/popular', ['topicList'], function (topicList) {
    const Popular = {};

    Popular.init = function () {
        app.enterRoom('popular_topics');
Severity: Minor
Found in public/src/client/popular.js and 2 other locations - About 35 mins to fix
public/src/client/recent.js on lines 3..13
public/src/client/top.js on lines 3..13

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    api.put = (route, payload, onSuccess) => call({
        url: route,
        method: 'put',
        data: JSON.stringify(payload),
        contentType: 'application/json; charset=utf-8',
Severity: Minor
Found in public/src/modules/api.js and 2 other locations - About 35 mins to fix
public/src/modules/api.js on lines 58..66
public/src/modules/api.js on lines 78..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

define('forum/recent', ['topicList'], function (topicList) {
    const Recent = {};

    Recent.init = function () {
        app.enterRoom('recent_topics');
Severity: Minor
Found in public/src/client/recent.js and 2 other locations - About 35 mins to fix
public/src/client/popular.js on lines 4..14
public/src/client/top.js on lines 3..13

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    api.post = (route, payload, onSuccess) => call({
        url: route,
        method: 'post',
        data: JSON.stringify(payload),
        contentType: 'application/json; charset=utf-8',
Severity: Minor
Found in public/src/modules/api.js and 2 other locations - About 35 mins to fix
public/src/modules/api.js on lines 68..76
public/src/modules/api.js on lines 78..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    api.del = (route, payload, onSuccess) => call({
        url: route,
        method: 'delete',
        data: JSON.stringify(payload),
        contentType: 'application/json; charset=utf-8',
Severity: Minor
Found in public/src/modules/api.js and 2 other locations - About 35 mins to fix
public/src/modules/api.js on lines 58..66
public/src/modules/api.js on lines 68..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

define('forum/top', ['topicList'], function (topicList) {
    const Top = {};

    Top.init = function () {
        app.enterRoom('top_topics');
Severity: Minor
Found in public/src/client/top.js and 2 other locations - About 35 mins to fix
public/src/client/popular.js on lines 4..14
public/src/client/recent.js on lines 3..13

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return true;
Severity: Major
Found in public/src/modules/helpers.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return;
    Severity: Major
    Found in src/middleware/admin.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return { flag: result.edit && (result.owner || result.isMod), message: '[[error:no-privileges]]' };
      Severity: Major
      Found in src/privileges/posts.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return '';
        Severity: Major
        Found in public/src/modules/helpers.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                              return;
          Severity: Major
          Found in public/src/ajaxify.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return false;
            Severity: Major
            Found in src/meta/blacklist.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return true;
              Severity: Major
              Found in src/middleware/user.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return e.preventDefault();
                Severity: Major
                Found in public/src/ajaxify.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return value;
                  Severity: Major
                  Found in public/src/modules/settings/checkbox.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return next();
                    Severity: Major
                    Found in src/middleware/admin.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return str;
                      Severity: Major
                      Found in public/src/utils.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                        return;
                        Severity: Major
                        Found in public/src/ajaxify.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                  return !res.headersSent;
                          Severity: Major
                          Found in src/middleware/user.js - About 30 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language