Sign upLogin

NodeBB/NodeBB

View on GitHub
Star

Showing 536 of 552 total issues

Function login has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

authenticationController.login = async (req, res, next) => {
    let { strategy } = await plugins.hooks.fire('filter:login.override', { req, strategy: 'local' });
    if (!passport._strategy(strategy)) {
        winston.error(`[auth/override] Requested login strategy "${strategy}" not found, reverting back to local login strategy.`);
        strategy = 'local';
Severity: Minor
Found in src/controllers/authentication.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addTags has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

async function addTags(topicData, req, res, currentPage) {
    const postIndex = parseInt(req.params.post_index, 10) || 0;
    const postAtIndex = topicData.posts.find(p => parseInt(p.index, 10) === parseInt(Math.max(0, postIndex - 1), 10));
    let description = '';
    if (postAtIndex && postAtIndex.content) {
Severity: Minor
Found in src/controllers/topics.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function details has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

groupsController.details = async function (req, res, next) {
    const lowercaseSlug = req.params.slug.toLowerCase();
    if (req.params.slug !== lowercaseSlug) {
        if (res.locals.isAPI) {
            req.params.slug = lowercaseSlug;
Severity: Minor
Found in src/controllers/groups.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

chatsController.get = async function (req, res, next) {
    if (meta.config.disableChat) {
        return next();
    }
Severity: Minor
Found in src/controllers/accounts/chats.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function method has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

    method: async function () {
        const groupsAPI = require('../../groups');
        const privilegesAPI = require('../../privileges');

        const cids = await db.getSortedSetRange('categories:cid', 0, -1);
Severity: Minor
Found in src/upgrades/1.1.0/assign_topic_read_privilege.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function method has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

    method: function (callback) {
        db.getObjectField('config', 'customJS', (err, newHTML) => {
            if (err) {
                return callback(err);
            }
Severity: Minor
Found in src/upgrades/1.7.0/generate-custom-html.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

Flags.create = async function (type, id, uid, reason, timestamp, forceFlag = false) {
    let doHistoryAppend = false;
    if (!timestamp) {
        timestamp = Date.now();
        doHistoryAppend = true;
Severity: Minor
Found in src/flags.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

usersAPI.update = async function (caller, data) {
    if (!caller.uid) {
        throw new Error('[[error:invalid-uid]]');
    }
Severity: Minor
Found in src/api/users.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function gdpr has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

Interstitials.gdpr = async function (data) {
    if (!meta.config.gdpr_enabled || (data.userData && data.userData.gdpr_consent)) {
        return data;
    }
    if (!data.userData) {
Severity: Minor
Found in src/user/interstitials.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function call has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

async function call(url, method, { body, timeout, jar, ...config } = {}) {
    let fetchImpl = fetch;
    if (jar) {
        fetchImpl = fetchCookie(fetch, jar);
    }
Severity: Minor
Found in src/request.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getNotifications has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

UserNotifications.getNotifications = async function (nids, uid) {
    if (!Array.isArray(nids) || !nids.length) {
        return [];
    }
Severity: Minor
Found in src/user/notifications.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function searchInContent has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

async function searchInContent(data) {
    data.uid = data.uid || 0;

    const [searchCids, searchUids] = await Promise.all([
        getSearchCids(data),
Severity: Minor
Found in src/search.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getCover has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

function getCover(type, id) {
    const defaultCover = `${relative_path}/assets/images/cover-default.png`;
    if (meta.config[`${type}:defaultCovers`]) {
        const covers = String(meta.config[`${type}:defaultCovers`]).trim().split(/[\s,]+/g);
        let coverPhoto = defaultCover;
Severity: Minor
Found in src/coverPhoto.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

chatsAPI.create = async function (caller, data) {
    if (await rateLimitExceeded(caller, 'lastChatRoomCreateTime')) {
        throw new Error('[[error:too-many-messages]]');
    }
    if (!data) {
Severity: Minor
Found in src/api/chats.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updatePrivilges has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

async function updatePrivilges() {
    // if email confirmation is required
    //   give chat, posting privs to "verified-users" group
    //   remove chat, posting privs from "registered-users" group
Severity: Minor
Found in src/upgrades/1.15.0/verified_users_group.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function method has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
Open

    method: async function () {
        let configJSON;
        try {
            configJSON = require('../../../config.json') || { [process.env.database]: true, database: process.env.database };
        } catch (err) {
Severity: Minor
Found in src/upgrades/1.7.3/key_value_schema_change.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language