Sign upLogin

NodeBB/NodeBB

View on GitHub
Star

Showing 536 of 552 total issues

Avoid too many return statements within this function.
Open

        return helpers.redirect(res, 'admin/manage/groups');
Severity: Major
Found in src/controllers/admin.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return helpers.redirect(res, `/category/${categoryFields.slug}?${qs.stringify(req.query)}`, true);
    Severity: Major
    Found in src/controllers/category.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return next();
      Severity: Major
      Found in src/controllers/groups.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return res.render('chats', payload);
        Severity: Major
        Found in src/controllers/accounts/chats.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return 'string';
          Severity: Major
          Found in src/database/mongo/main.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return await prompt.get(questions.postgres);
            Severity: Major
            Found in install/databases.js - About 30 mins to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

              privsAdmin.getGroupPrivilegeList = async () => await plugins.hooks.fire('filter:privileges.admin.groups.list', Array.from(_privilegeMap.keys()).map(privilege => `groups:${privilege}`));
              Severity: Minor
              Found in src/privileges/admin.js and 2 other locations - About 30 mins to fix
              src/privileges/categories.js on lines 57..57
              src/privileges/global.js on lines 58..58

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                      const [followers, following] = await Promise.all([
            db.getSortedSetRange(`followers:${uid}`, 0, -1),
            db.getSortedSetRange(`following:${uid}`, 0, -1),
        ]);
              Severity: Minor
              Found in src/user/delete.js and 2 other locations - About 30 mins to fix
              src/upgrades/1.15.0/remove_flag_reporters_zset.js on lines 15..18
              src/user/delete.js on lines 182..185

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 65.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this function.
              Open

                          return config;
              Severity: Major
              Found in install/databases.js - About 30 mins to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        const [upvotedPids, downvotedPids] = await Promise.all([
            db.getSortedSetRange(`uid:${uid}:upvote`, 0, -1),
            db.getSortedSetRange(`uid:${uid}:downvote`, 0, -1),
        ]);
                Severity: Minor
                Found in src/user/delete.js and 2 other locations - About 30 mins to fix
                src/upgrades/1.15.0/remove_flag_reporters_zset.js on lines 15..18
                src/user/delete.js on lines 206..209

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                                const [reports, reporterUids] = await Promise.all([
                    db.getSortedSetRevRangeWithScores(`flag:${flagId}:reports`, 0, -1),
                    db.getSortedSetRevRange(`flag:${flagId}:reporters`, 0, -1),
                ]);
                Severity: Minor
                Found in src/upgrades/1.15.0/remove_flag_reporters_zset.js and 2 other locations - About 30 mins to fix
                src/user/delete.js on lines 182..185
                src/user/delete.js on lines 206..209

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                privsCategories.getGroupPrivilegeList = async () => await plugins.hooks.fire('filter:privileges.groups.list', Array.from(_privilegeMap.keys()).map(privilege => `groups:${privilege}`));
                Severity: Minor
                Found in src/privileges/categories.js and 2 other locations - About 30 mins to fix
                src/privileges/admin.js on lines 43..43
                src/privileges/global.js on lines 58..58

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                privsGlobal.getGroupPrivilegeList = async () => await plugins.hooks.fire('filter:privileges.global.groups.list', Array.from(_privilegeMap.keys()).map(privilege => `groups:${privilege}`));
                Severity: Minor
                Found in src/privileges/global.js and 2 other locations - About 30 mins to fix
                src/privileges/admin.js on lines 43..43
                src/privileges/categories.js on lines 57..57

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 65.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function build has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
                Open

                exports.build = async function (targets, options) {
    if (!options) {
        options = {};
    }
                Severity: Minor
                Found in src/meta/build.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function fireFilterHook has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
                Open

                async function fireFilterHook(hook, hookList, params) {
    if (!Array.isArray(hookList) || !hookList.length) {
        return params;
    }
                Severity: Minor
                Found in src/plugins/hooks.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function exports has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
                Open

                module.exports = function (SocketTopics) {
    SocketTopics.loadTopicTools = async function (socket, data) {
        if (!socket.uid) {
            throw new Error('[[error:no-privileges]]');
        }
                Severity: Minor
                Found in src/socket.io/topics/tools.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function redirect has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
                Open

                helpers.redirect = function (res, url, permanent) {
    // this is used by sso plugins to redirect to the auth route
    // { external: '/auth/sso' } or { external: 'https://domain/auth/sso' }
    if (url.hasOwnProperty('external')) {
        const redirectUrl = encodeURI(prependRelativePath(url.external));
                Severity: Minor
                Found in src/controllers/helpers.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function connect has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
                Open

                connection.connect = async function (options) {
    return new Promise((resolve, reject) => {
        options = options || nconf.get('redis');
        const redis_socket_or_host = options.host;
                Severity: Minor
                Found in src/database/redis/connection.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function create has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
                Open

                pagination.create = function (currentPage, pageCount, queryObj) {
    if (pageCount <= 1) {
        return {
            prev: { page: 1, active: currentPage > 1 },
            next: { page: 1, active: currentPage < pageCount },
                Severity: Minor
                Found in src/pagination.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function generateForTopic has a Cognitive Complexity of 11 (exceeds 10 allowed). Consider refactoring.
                Open

                async function generateForTopic(req, res, next) {
    if (meta.config['feeds:disableRSS']) {
        return next();
    }
                Severity: Minor
                Found in src/routes/feeds.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language